Allow setting CachingPolicy for the request

[galmeida]

That's it. It would be nice to have a way to set a CachingPolicy for request.

[haacked]

Want to take a crack at it and submit a PR?

[galmeida]

tks @andrzejpindor, you're amazingly fast. I only had to time fork the repo and you're already submitted a PR

[galmeida]

sorry @andrzejpindor, I'm new to RestSharp, but if I understand your patch, it allows us to set a default cache policy through app config, but does not allows to set cache policy per request, is that right? Maybe we should have a RequestPolicyCache property on RestClient. What do you think?

@galmeida - I'm new to RestSharp too ;) Take a look at my changes - you'll see property RequestCachePolicy added to IHttp. This property allows to set custom policy (which default is app/web config settings). Next, this property is used to setup RestClient. I don't insist on this solution, but it is similar to "Timeout" which is set in the same way.

[edit]
ha, @galmeida - thanks to your reply I noticed that I haven't added property to the interface (IHttp) but only to implementation. I'll fix it today.

[galmeida]

@andrzejpindor - I took a look at your patch, but based on sample usage I saw on RestSharp docs and some source code reading, it seems to me that IHttp is not accessible outside RestSharp framework. Could you please post a sample code on how to set the Caching Policy on a specific request?

@galmeida - you are absolutely right :) please take a look at the improved solution: https://github.com/andrzejpindor/RestSharp/compare/401-CachingPolicy
If this is what you wanted?

Now you can do something like this:

var client = new RestClient("http://example.com");
client.CachePolicy = new HttpRequestCachePolicy(HttpRequestCacheLevel.Revalidate);

[galmeida]

Yes, this is exactly what I was planning to do.

Thank you.

[galmeida]

any plans to accept this PR?

[whoelse-NET]

@haacked - can you take a look for my pull request, please?

[haacked]

@whoelse-NET I did! Did you see my questions?

[dgreenbean]

I just created a pull request for a more limited version of the original change proposed. This does not change the default functionality, but it does add the ability to set the cache policy on a client.

This is important, as the only workaround currently is to set the cache policy globally for a process. In general, it is better to limit the scope of the policy to a specific client wrapper, i.e. only specific requests.

[elmerillion]

This was merged but doesn't appear to be active due to the "#if FRAMEWORK" checks. Is there a compiler directive missing?