Conversation
…ion copy - OptionsPanel: remove green 'Active' badge from wired settings; only 'Planned' badges render now. - OptionsPanel: reword 'Audio Conversion' description to reflect that MP3 and AAC outputs are both supported via the encoding preset. - seed: default audioEncodingPreset is now mp3_32k (matching the dropdown's '(default)' label and audio.ParseEncodingPreset's fallback) instead of aac_lc_32k. - audio/worker.go: move the '(default)' comment marker from PresetAACLC32k onto PresetMP3_32k to match the seed and parser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small admin-options fixes reported in dev testing.
Changes
Frontend —
OptionsPanel.tsxaudioConversiondescription from "Convert incoming audio to AAC/M4A using FFmpeg." to "Convert incoming audio with FFmpeg before storing. Select the codec and bitrate below." — the old copy implied AAC/M4A only, but MP3 outputs are equally supported via the encoding preset.Backend — seed + worker
internal/seed/seed.go: defaultaudioEncodingPresetchanged fromaac_lc_32k→mp3_32k. This was the actual root cause of the reported bug. The dropdown labelsmp3_32kas "(default)" andaudio.ParseEncodingPresetfalls back tomp3_32kon empty/unknown input, but the seed contradicted both by writingaac_lc_32kto the settings row at install time, so freshly-installed instances saw AAC-LC 32k preselected the moment audio conversion was enabled.internal/audio/worker.go: moved the(default)comment marker offPresetAACLC32kand ontoPresetMP3_32kso the source of truth matches the seed and parser fallback.Verification
go vet ./...andgo build ./...clean.pnpm exec tsc --noEmitclean.PresetMP3_32kis the parser fallback, so no test changes needed.CHANGELOG
Updated under
[Unreleased]— two entries under Changed (Active badge, audio-conversion copy) and one under Fixed (MP3 default seed).