refactor(frontend): split types/index.ts into topic-scoped modules (Phase 6)#22
Merged
refactor(frontend): split types/index.ts into topic-scoped modules (Phase 6)#22
Conversation
…hase 6)
Phase 6 of the directory restructure plan. The 413-line types/index.ts
god-file is split into seven topic-scoped modules; the original path
becomes a barrel that re-exports everything so all existing @/types
import sites continue to compile unchanged.
New layout:
- types/call.ts - Call, TranscriptionSegment
- types/config.ts - SystemConfig, TalkgroupConfig, ScannerConfig
- types/ws.ts - WsCommand, ConnectionStatus
- types/auth.ts - LoginResponse, RefreshResponse, ChangePasswordRequest
- types/api.ts - SetupStatus
- types/admin.ts - All Admin* DTOs, Capabilities, ConfigResponse,
CreateUserPayload, UpdateUserPayload, RR*,
SharedLinkAdmin, ServerDirectory*, Transcription*
- types/ui.ts - AvoidEntry
- types/index.ts - barrel re-export
No type signatures or behaviour changed. tsc --noEmit clean,
188/188 unit tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 6 of the directory restructure plan. The 413-line
types/index.tsgod-file is split into seven topic-scoped modules; the original path becomes a barrel that re-exports everything so all existing@/typesimport sites continue to compile unchanged.New layout
types/call.tsCall,TranscriptionSegmenttypes/config.tsSystemConfig,TalkgroupConfig,ScannerConfigtypes/ws.tsWsCommand,ConnectionStatustypes/auth.tsLoginResponse,RefreshResponse,ChangePasswordRequesttypes/api.tsSetupStatustypes/admin.tsAdmin*DTOs,Capabilities,ConfigResponse,CreateUserPayload,UpdateUserPayload, RR* enrichment,SharedLinkAdmin,ServerDirectory*, transcription DTOstypes/ui.tsAvoidEntrytypes/index.tsNo type signatures or behaviour changed. No call-site imports needed updating because the barrel covers the existing
@/typessurface.Verification
pnpm exec tsc --noEmit— cleanpnpm test -- --run— 188/188 passPhase progress
/api/wscanonical +/wsaliasinternal/adminextractioninternal/apidecomposition (refactor(backend): Phase 3 — decompose internal/api into feature-scoped handler packages #18)After this merges, only the optional Phase 7 (move
backend/migrations/→backend/db/migrations/) remains.CHANGELOG
One bullet appended under
[Unreleased]### Changed.