Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 804a9a1047
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fun IntervalTimerTheme( | ||
| darkTheme: Boolean = isSystemInDarkTheme(), | ||
| fun IniTheme( | ||
| darkTheme: Boolean = true, |
There was a problem hiding this comment.
Follow system theme instead of forcing dark mode
IniTheme now defaults darkTheme to true, and current call sites use the default, so the app always renders with DarkColorScheme even when the device is in light mode. This makes LightColorScheme effectively unreachable in normal app usage and regresses expected Material behavior for users who prefer light theme.
Useful? React with 👍 / 👎.
| painterResource(res.drawable.ic_plus) | ||
| else | ||
| painterResource(res.drawable.ic_minus), | ||
| contentDescription = null, |
There was a problem hiding this comment.
Provide accessibility labels for icon-only buttons
IniButtonPicker renders an IconButton whose icon has contentDescription = null, which produces unlabeled controls for screen-reader users. This component is used for primary interactive actions (including icon-only entry and +/- controls), so assistive-tech users cannot reliably understand what each button does.
Useful? React with 👍 / 👎.
Implement ini Theme
Improve AddTimerScreen UI