Skip to content

#14 UI enhancement#17

Merged
rezapour merged 2 commits intodevelopfrom
feature/14-ui-enhancement
Apr 12, 2026
Merged

#14 UI enhancement#17
rezapour merged 2 commits intodevelopfrom
feature/14-ui-enhancement

Conversation

@rezapour
Copy link
Copy Markdown
Owner

Implement ini Theme
Improve AddTimerScreen UI

@rezapour rezapour linked an issue Apr 12, 2026 that may be closed by this pull request
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 804a9a1047

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fun IntervalTimerTheme(
darkTheme: Boolean = isSystemInDarkTheme(),
fun IniTheme(
darkTheme: Boolean = true,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Follow system theme instead of forcing dark mode

IniTheme now defaults darkTheme to true, and current call sites use the default, so the app always renders with DarkColorScheme even when the device is in light mode. This makes LightColorScheme effectively unreachable in normal app usage and regresses expected Material behavior for users who prefer light theme.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix it latter

painterResource(res.drawable.ic_plus)
else
painterResource(res.drawable.ic_minus),
contentDescription = null,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Provide accessibility labels for icon-only buttons

IniButtonPicker renders an IconButton whose icon has contentDescription = null, which produces unlabeled controls for screen-reader users. This component is used for primary interactive actions (including icon-only entry and +/- controls), so assistive-tech users cannot reliably understand what each button does.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix it later

@rezapour rezapour merged commit f83e1de into develop Apr 12, 2026
1 check passed
@rezapour rezapour deleted the feature/14-ui-enhancement branch April 12, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI enhancement

1 participant