Skip to content

Update binary lens caustic class for MuLensModel 3.4.0#35

Merged
AmberLee2427 merged 2 commits intomainfrom
copilot/fix-caustics-class-name
Dec 22, 2025
Merged

Update binary lens caustic class for MuLensModel 3.4.0#35
AmberLee2427 merged 2 commits intomainfrom
copilot/fix-caustics-class-name

Conversation

Copy link
Contributor

Copilot AI commented Dec 22, 2025

MulensModel 3.4.0 renamed the binary caustic helper used in the AAS Session C notebook, breaking the binary lens exercises that call the old Caustics class.

  • Notebook adjustment: In Session C “Fitting_Binary_Lenses”, replace the deprecated mm.Caustics with mm.CausticsBinary for both the interactive slider plot and the example magnification/trajectory plot so the notebook runs against MuLensModel 3.4.0.

Example update:

# Binary lens caustic and critical curves
binary_caustic = mm.CausticsBinary(s=s, q=q)
bx, by = binary_caustic.get_caustics()
Original prompt

This section details on the original issue you should resolve

<issue_title>Conflicting Versions of MuLensModel</issue_title>
<issue_description>I noticed MuLensModel version 3.4.0 is required in the env.yml. I think this adds a conflict with the AAS session C notebook on binary lenses. The notebook calls the Caustics class, see for example Exercise 1. In version 3.4.0, the Caustics class was refactored to CausticsBinary. A simple refactoring fixes this. </issue_description>

<agent_instructions>Only edit the notebooks in AAS_Workshop or Extras. Other versions are automation artifacts.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Dec 22, 2025
Co-authored-by: AmberLee2427 <26697369+AmberLee2427@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix conflicting class name in AAS session C notebook Update binary lens caustic class for MuLensModel 3.4.0 Dec 22, 2025
Copilot AI requested a review from AmberLee2427 December 22, 2025 09:41
@AmberLee2427 AmberLee2427 marked this pull request as ready for review December 22, 2025 09:46
@AmberLee2427 AmberLee2427 merged commit e2d0bfb into main Dec 22, 2025
@AmberLee2427 AmberLee2427 deleted the copilot/fix-caustics-class-name branch January 15, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conflicting Versions of MuLensModel

2 participants