add argocd-image-updater component#316
Merged
svghadi merged 6 commits intoOct 12, 2025
Merged
Conversation
chengfang
force-pushed
the
image.updater.in.1.19
branch
from
5f88161 to
043a715
Compare
Collaborator
|
/retest |
2 similar comments
Collaborator
|
/retest |
Collaborator
Author
|
/retest |
chengfang
force-pushed
the
image.updater.in.1.19
branch
from
043a715 to
79ec266
Compare
Signed-off-by: Cheng Fang <cfang@redhat.com>
chengfang
force-pushed
the
image.updater.in.1.19
branch
from
79ec266 to
243ab57
Compare
…vailable in ubi-minimal Signed-off-by: Cheng Fang <cfang@redhat.com>
…1.34.34 Signed-off-by: Cheng Fang <cfang@redhat.com>
chengfang
force-pushed
the
image.updater.in.1.19
branch
from
136723b to
5ae17e5
Compare
…n building argocd-image-updater Signed-off-by: Cheng Fang <cfang@redhat.com>
chengfang
force-pushed
the
image.updater.in.1.19
branch
from
5ae17e5 to
f9957ee
Compare
Signed-off-by: Cheng Fang <cfang@redhat.com>
Signed-off-by: Cheng Fang <cfang@redhat.com>
Collaborator
|
Is aws-cli a hard requirement for image updater? |
Collaborator
Author
No, it's nice to have for those ECR users calling awscli to get a token. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: argocd-image-updater upstream Dockerfile uses alpines and installs awscli along with other alpine packages. In the downstream Dockerfile in this PR, awscli is not included because it is not available as a package in ubi. The other option would be to install python3 package, and use pip install awscli (v1 only, current version is 2), but even that would require adding a lot of dependencies to prefetch, if it is possible at all.