Skip to content

feat(sdk): add gateway, auth, fakes, and edge client (2/4)#10

Open
rhuss wants to merge 3 commits into
go-sdk-1-foundationfrom
go-sdk-2-auth-fakes
Open

feat(sdk): add gateway, auth, fakes, and edge client (2/4)#10
rhuss wants to merge 3 commits into
go-sdk-1-foundationfrom
go-sdk-2-auth-fakes

Conversation

@rhuss

@rhuss rhuss commented Jul 11, 2026

Copy link
Copy Markdown
Owner

Summary

Add the gateway client (reads CLI config), OIDC authentication with token refresh, edge/tunnel client, and in-memory fake implementations for testing.

Part 2 of 4 for #2044. Depends on PR 1 (foundation).

What's Included

  • Gateway client (gateway/): Reads ~/.config/openshell/ config, resolves auth automatically
  • OIDC authentication (oidc/): Discovery, device-code flow, auth-code flow, token management
  • Edge client (edge/): Cloudflare tunnel integration for edge API access
  • Fake implementations (fake/): In-memory fakes mirroring real client validation for testing

File Tree

sdk/go/openshell/v1/
├── gateway/     # 12 files - Gateway client factory + config reader
├── oidc/        # 22 files - OIDC authentication flows
├── edge/        #  5 files - Edge API + tunnel proxy
└── fake/        # 31 files - In-memory test fakes

70 files

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 78db4239-1315-4c9b-b256-d939e9e60005

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch go-sdk-2-auth-fakes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rhuss
rhuss marked this pull request as ready for review July 11, 2026 10:43
@rhuss
rhuss requested a review from Copilot July 11, 2026 10:43
devin-ai-integration[bot]

This comment was marked as resolved.

This comment was marked as resolved.

@rhuss
rhuss force-pushed the go-sdk-2-auth-fakes branch 3 times, most recently from 8ec90d2 to b5db057 Compare July 11, 2026 11:05
Add the gateway client (reads CLI config), OIDC authentication with
token refresh, edge/tunnel client, and in-memory fake implementations
for testing.

Part 2 of 4 for issue NVIDIA#2044.
Assisted-By: 🤖 Claude Code

Signed-off-by: Roland Huß <rhuss@redhat.com>
@rhuss
rhuss force-pushed the go-sdk-2-auth-fakes branch from b5db057 to edbf3ed Compare July 11, 2026 11:11
@rhuss

rhuss commented Jul 11, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Applied fixes from bot review comments:
- Comment #3563989616: add nil check to fakeProviderClient.Create
- Comment #3563989625: add nil check to fakeProviderClient.Update
- Comment #3563989635: add nil check to fakeProviderClient.Ensure
- Comment #3563989656: fix misleading comment about logging readErr in oidc.Login

Assisted-By: 🤖 Claude Code
Signed-off-by: Roland Huß <rhuss@redhat.com>
rhuss added a commit that referenced this pull request Jul 11, 2026
Lower the minimum Go version to 1.24.0, matching PR #9.

Assisted-By: 🤖 Claude Code
rhuss added a commit that referenced this pull request Jul 11, 2026
Lower the minimum Go version to 1.24.0, matching PR #9.

Assisted-By: 🤖 Claude Code
@rhuss
rhuss force-pushed the go-sdk-2-auth-fakes branch from 2749499 to 552e801 Compare July 11, 2026 13:27
Lower the minimum Go version to 1.24.0, matching PR #9.

Assisted-By: 🤖 Claude Code
@rhuss
rhuss force-pushed the go-sdk-2-auth-fakes branch from 552e801 to db75560 Compare July 11, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants