Allow polling period to be set at instantiation.#6
Merged
Conversation
Allows the polling period of the caching thread to be set when the thread is instantiated. Allow for stopping the thread in a safe manner. Add a unit test caching_thread.
jhmartin
reviewed
Jul 3, 2025
Owner
|
Hell yeah, thankyou (And thankyou for adding tests). The |
Contributor
Author
|
Let me know if there is a desire to change the empty_stats back to None. |
Owner
|
Yeah if you can set it back to |
Contributor
Author
|
Changed back to initializing to None. Tests updated as well. |
Owner
|
Thanks! Testing locally and then I'll cut new releases |
Owner
|
I just cut |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The home assistant franklin component calls this library and it would be good if the home assistant component could set the polling time. This PR is the first step towards enabling home assistant to set the polling time.
Allows the polling period of the caching thread to be set when the thread is instantiated.
The default polling interval is set to be backwards compatible.
Allow for stopping the thread in a safe manner which makes testing easier.
Add a unit test for the caching_thread.