Operator integration hardening#544
Open
GavriloviciEduard wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark the type contribution you are making:
Description
This is a hardening pass on the existing Epilogue Operator experimental feature. It fixes data-loss and UI edge cases surfaced during on-device testing, plus improves cartridge detection.
What this PR changes:
Why is this change necessary?
On-device testing of the shipped Operator feature exposed several ways a cartridge session could lose save data or leave the library UI in a wrong/flashing state (e.g. an interrupted save write, a removed cartridge still reading as inserted, launching before the save was read).
Why did you decide on this solution?
operatorDeviceflag and inside the isolated+OperatorSwift extensions /DeltaOperator+OperatorKitlayer, so upstream Delta code paths are barely touched.Testing
Tested on the following, all running the latest iOS release:
Checklist
General (All PRs)
Experimental Feature-specific
ExperimentalFeaturesstruct annotated with@Feature@Option's to persist all feature-related dataExperimentalFeatures.shared.[feature].isEnabledruntime check