Add Fast Forward Speed Picker experimental feature#547
Open
adamgrushan wants to merge 1 commit into
Open
Conversation
Adds a new experimental feature that lets users pick a single preferred fast forward speed (2x/3x/4x/8x, or Maximum) that applies across all systems. Speeds above a system's maximum supported rate are capped. Precedence: per-game speed > per-system speed (Custom Fast Forward Speed) > global picker speed > system maximum. The feature has no effect when disabled. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark the type contribution you are making:
Description
Summary of your changes, including:
Delta's existing "Custom Fast Forward Speed" experimental feature requires configuring a preferred speed per system (NES, SNES, N64, etc.). Many players just want one fast-forward speed everywhere without setting it seven times. This adds a "Fast Forward Speed Picker" experimental feature: a single picker option (2x, 3x, 4x, 8x, or Maximum) that applies across all systems. Speeds above a system's maximum supported rate are automatically capped at that maximum, so one global choice is always safe.
Docs/ExperimentalFeatures.md, reusing the existingFastForwardSpeedtype (alreadyLocalizedOptionValue-conforming) so the picker displays consistent "2x"-style labels and a "Maximum" nil choice.Delta/Experimental Features/Features/FastForwardSpeedPicker.swift) containing the options struct and aGameViewControllerextension, per the isolation guidance.performFastForwardAction's speed resolution: per-game speed > per-system speed (Custom Fast Forward Speed) > global picker speed > system maximum. This keeps the new feature composable with the existing one and guarantees no behavior change when disabled (the gating property returnsnilunlessExperimentalFeatures.shared.fastForwardSpeedPicker.isEnabled).Testing
List all iOS versions and devices you've tested this change on.
Example Configurations:
Checklist
General (All PRs)
Experimental Feature-specific
ExperimentalFeaturesstruct annotated with@Feature@Option's to persist all feature-related dataExperimentalFeatures.shared.[feature].isEnabledruntime check🤖 Generated with Claude Code