Conversation
7ecdcab to
386ddff
Compare
067b8e7 to
7118af6
Compare
7118af6 to
b21c0fd
Compare
58826c1 to
ac2f48b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
Also: |
notxvilka
left a comment
There was a problem hiding this comment.
Also tests fail on Big Endian machine: https://app.travis-ci.com/github/rizinorg/rizin/jobs/638193261#L4765
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 20 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
notxvilka
left a comment
There was a problem hiding this comment.
Minor things still left:
16m 49s
Run python3 rz-bindgen/src/lint.py \
Missing type comment at <rizin/librz/bin/format/ecoff/ecoff.c:97:1> (token is not a comment)
Missing type comment at <rizin/librz/bin/format/ecoff/ecoff.c:98:1> (token is not a comment)
Error: Process completed with exit code 2.
[XX] 00h00m00s189ms db/formats/ecoff Alpha 64 ECOFF
RZ_NOPLUGINS=1 /home/travis/build/rizinorg/rizin/install/bin/rizin -escr.utf8=0 -escr.color=0 -escr.interactive=0 -eflirt.sigdb.load.system=false -esearch.show_progress=false -eflirt.sigdb.load.home=false -N -qc 'echo "=== bin ==="
iH
echo "=== info ==="
it
echo "=== entrypoints ==="
iet
echo "=== exports ==="
iEt
echo "=== imports ==="
iit
echo "=== symbols ==="
ist
echo "=== sections ==="
iSt
pdf
' bins/ecoff/alpha/gettext
-- stdout
--- expected
+++ actual
@@ -14,7 +14,7 @@
- "CALL_SHARED"
aouthdr:
magic: "ZMAGIC (0x010b)"
- vstamp: "v3.13"
+ vstamp: "v13.3"
bldrev: 0xc
padding: 0x0
tsize: 0x6000
-- stderr
ERROR: Cannot find function at 0x120001c30
https://app.travis-ci.com/github/rizinorg/rizin/jobs/638201759#L4660
|
the linter issue is probably a bug on the linter, because i use RzPVector & RzVector and i have defined the types. |
Your checklist for this pull request
RZ_APIfunction and struct this PR changes.RZ_API).Detailed description
Adds support to parse ECOFF file format with support only for alpha & mips.
Relocs are not supported as i cannot find binaries to implement them
Fix #4302