Fixed a buffer overflow in gdbr_parse_processes_xml#5973
Merged
notxvilka merged 4 commits intorizinorg:devfrom Mar 3, 2026
Merged
Fixed a buffer overflow in gdbr_parse_processes_xml#5973notxvilka merged 4 commits intorizinorg:devfrom
notxvilka merged 4 commits intorizinorg:devfrom
Conversation
notxvilka
requested changes
Feb 27, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 27 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
Author
|
@notxvilka Can you take a look again? |
wargio
approved these changes
Mar 3, 2026
wargio
reviewed
Mar 3, 2026
…ession test for it
Co-authored-by: Giovanni <561184+wargio@users.noreply.github.com>
notxvilka
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
RZ_APIfunction and struct this PR changes.RZ_API).Detailed description
This fixes #5882, The issue was that the cmdline buffer size was too small for some of the data that gdbserver sends with the
--multiflag. The fix was to simply increase the buffer size of cmdline.Test plan
gdbserver --multi :4444rizin -d gdb://localhost:4444dpAdditionally I made a test for this in test/db/archos/linux-x64/dbg_gdbserver
Closing issues
closes #5882