refactor(rlix-validation): drop unreachable per-engine contiguity loop in C6-mapping#25
Open
TianyeGGBond wants to merge 1 commit into
Conversation
…p in C6-mapping The preceding check already asserts infer_device_mapping == range(len), so every per_engine slice is contiguous by construction and the loop can never raise. Remove the dead code. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
In
assert_rlix_topology, the C6-mapping check enforces that the inference device mapping is a sorted, contiguous, zero-based list, and that each engine occupies a contiguous GPU range:Problem
Check (2) is dead code. Once check (1) passes,
infer_device_mappingis exactly[0, 1, ..., n-1]. Slicing a fully-contiguous zero-based list intoper_engine-sized chunks always yields contiguous ranges, sogroup == expectedis guaranteed and the loop'sraisecan never fire.Change
Remove the loop. Check (1) alone fully enforces the C6-mapping invariant. No behavioral change — the removed branch was unreachable.
🤖 Generated with Claude Code