refactor(rlix-validation): read model_update_transport once#26
Open
TianyeGGBond wants to merge 1 commit into
Open
refactor(rlix-validation): read model_update_transport once#26TianyeGGBond wants to merge 1 commit into
TianyeGGBond wants to merge 1 commit into
Conversation
`transport` was fetched twice inside assert_rlix_topology (C11 and S2) from the same arg. Hoist it into the top-of-function derived block so there is a single source. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
assert_rlix_topologyreadsargs.model_update_transportin two places:if is_rlix_mode():) to enforcecpu_serializein RLix modehas_gpu_staging(whether a GPU-staging transport is in play)The C11 copy is scoped inside the
is_rlix_mode()branch, so S2 can't reuse it and re-reads the same arg with the same default.Change
Fetch
transportonce in the top-of-function derived block (alongsidetrain,infer,engine_count,per_engine) and drop both local re-reads. Single source, no behavioral change.🤖 Generated with Claude Code