refactor(rlix-validation): remove deprecated no-op assert_partial_overlap_standalone_safe#27
Open
TianyeGGBond wants to merge 1 commit into
Conversation
…rlap_standalone_safe The function was a documented no-op with no callers. Drop it and its __all__ entry. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
assert_partial_overlap_standalone_safewas originally meant to refuse partial-overlap topologies under the standalone (train_async.py) entry. Its own docstring explains it was reduced to a no-op because intent can't be safely classified from args alone at the standalone entry (the standalonecreate_placement_groupspath offsets the rollout pool, so a valid disjoint config also looks like zero-basedtrain ⊂ infer). The reliable signal is theRLIX_CONTROL_PLANE=rlixenv var, and RLix-mode correctness is already enforced byassert_rlix_topology(C1).Problem
The function does nothing and — verified across the miles tree — has no callers. It's only referenced by its own
__all__entry. Keeping a no-op in the public API is dead weight and misleads readers into thinking a standalone guard exists.Change
Delete the function and its
__all__entry. No callers, no behavioral change.🤖 Generated with Claude Code