refactor(rlix): use shared is_rlix_mode() in multi_turn generate#29
Open
TianyeGGBond wants to merge 1 commit into
Open
Conversation
multi_turn defined a private _is_rlix_mode() that hand-copied the
`os.environ.get("RLIX_CONTROL_PLANE") == "rlix"` check, duplicating the
canonical helper in miles/utils/rlix_validation.py. Its stated reason was
to avoid importing rlix_validation, but that module only depends on the
stdlib (os/shutil/logging/typing), so importing it is free and cannot
break importability.
Import is_rlix_mode() directly, drop the duplicate function and the now
unused `import os`.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
miles/rollout/generate_hub/multi_turn.pydefined a private_is_rlix_mode()that hand-copied theos.environ.get("RLIX_CONTROL_PLANE") == "rlix"check already owned bythe canonical
is_rlix_mode()inmiles/utils/rlix_validation.py.The duplicate's docstring justified itself as avoiding an import
dependency ("multi_turn must remain importable even when the
rlix_validation module is absent in legacy installations"). That
rationale does not hold:
rlix_validationimports only the stdlib(
os/shutil/logging/typing), so importing it is free andcannot break importability. The result was a second, drifting copy of
the env-flag contract.
Change points
is_rlix_modefrommiles.utils.rlix_validation_is_rlix_mode()functionrlix_mode = _is_rlix_mode()→is_rlix_mode())import osNo behavior change. Diff: 2 insertions / 9 deletions in 1 file.
🤖 Generated with Claude Code