refactor(rlix): add get_coordinator_actor_name helper (F7)#27
Merged
zhenyulincs merged 1 commit intoJun 21, 2026
Conversation
Both the scheduler and the miles drivers built the per-pipeline coordinator
actor name by hand-writing f"{COORDINATOR_ACTOR_NAME_PREFIX}{pipeline_id}".
The namespace half of the same convention is already centralized in
get_pipeline_namespace(); centralize the name half next to it so both are
single-sourced and cannot drift.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
F7 (per-pipeline Ray namespace isolation) needs the central scheduler and the
miles drivers to agree on the coordinator actor's name. Today both sides
build that name by hand-writing the same f-string
f"{COORDINATOR_ACTOR_NAME_PREFIX}{pipeline_id}"in separate files.The namespace half of the same convention is already centralized in
get_pipeline_namespace(), but the name half is not — leaving two copies thatcan silently drift apart. That drift is exactly the class of mismatch behind the
M11.1 "Failed to resolve actor" bug.
Change
rlix/protocol/types.py: addget_coordinator_actor_name(pipeline_id), acompanion to
get_pipeline_namespace(pipeline_id), so the name and namespaceconventions are both single-sourced.
rlix/scheduler/scheduler.py: use the helper in_get_or_lookup_coordinator_handle_locked; drop the now-unusedCOORDINATOR_ACTOR_NAME_PREFIXimport.No behavior change — the produced actor name is identical.
Related
The miles drivers (
examples/rlix/run_miles_rlix.py,run_miles_dual.py) buildthe same name. A companion PR in rlops/miles switches them to this helper.
That PR imports
get_coordinator_actor_namefromrlix.protocol.types, sothis PR should merge first.