Skip to content

doc: renamed "source activate" -> "conda activate"#1056

Closed
Maltimore wants to merge 1 commit intorlworkgroup:masterfrom
Maltimore:conda_activate
Closed

doc: renamed "source activate" -> "conda activate"#1056
Maltimore wants to merge 1 commit intorlworkgroup:masterfrom
Maltimore:conda_activate

Conversation

@Maltimore
Copy link
Copy Markdown

@Maltimore Maltimore commented Nov 20, 2019

Since conda 4.4, the command to activat an environment is "conda activate", not "source activate".

Conda 4.4 was released around 2 years ago, and I think most people would have updated by now.

https://www.anaconda.com/how-to-get-ready-for-the-release-of-conda-4-4/

@Maltimore Maltimore requested a review from a team as a code owner November 20, 2019 14:28
@ryanjulian
Copy link
Copy Markdown
Member

ryanjulian commented Nov 20, 2019

@Maltimore thanks for the PR!
Your PR is going to fail jobs 2 and 3 in TravisCI because our test suite still requires a private MuJoCo license key, which is not shared with forks (for security reasons).

Can you update it until the pre-commit checks pass? Then we will pull it into a branch in this repo so it can pass the CI.

Your pre-commit checks are failing because your commit messages doesn't conform to the format we use, as described in CONTRIBUTING.md. You should be able to amend your commit message and pass easily.

@ryanjulian ryanjulian mentioned this pull request Nov 20, 2019
Closed
@ryanjulian ryanjulian requested a review from a team November 20, 2019 21:56
@ghost ghost requested review from nish21 and yonghyuc and removed request for a team November 20, 2019 21:56
@Maltimore
Copy link
Copy Markdown
Author

Maltimore commented Nov 21, 2019 •
edited
Loading

I mindlessly force-pushed after rebasing, before amending the commit. Please ignore.

Maltimore added a commit to Maltimore/garage that referenced this pull request Nov 21, 2019
@Maltimore
Doc: renamed "source activate" (rlworkgroup#1056)
c6b76eb 
renamed "source activate" -> "conda activate"
In conda 4.4, the way to activate an environment was changed this way.
@ryanjulian
Copy link
Copy Markdown
Member

ryanjulian commented Nov 21, 2019

@Mergifyio backport master

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Nov 21, 2019

Command backport master: pending

Waiting for the pull request to get merged

Hey, we reacted but our real name is @Mergifyio

@ryanjulian
Copy link
Copy Markdown
Member

ryanjulian commented Nov 21, 2019

@Mergifyio rebase

@Maltimore
Doc: renamed "source activate" (rlworkgroup#1056)
5faf27e 
renamed "source activate" -> "conda activate"
In conda 4.4, the way to activate an environment was changed this way.
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Nov 21, 2019

Command rebase: success

Branch has been successfully rebased

Hey, we reacted but our real name is @Mergifyio

@ryanjulian
Copy link
Copy Markdown
Member

ryanjulian commented Nov 21, 2019

See #1064 where this will actually be merged. Thanks @Maltimore

@ryanjulian ryanjulian closed this Nov 21, 2019
mergify Bot pushed a commit that referenced this pull request Nov 22, 2019
@ryanjulian @mergify
Doc: renamed "source activate" (#1056) (#1064)
7f49c4e 
renamed "source activate" -> "conda activate"
In conda 4.4, the way to activate an environment was changed this way.
mergify Bot pushed a commit that referenced this pull request Nov 22, 2019
@ryanjulian
Doc: renamed "source activate" (#1056) (#1064)
84c6480 
renamed "source activate" -> "conda activate"
In conda 4.4, the way to activate an environment was changed this way.

(cherry picked from commit 7f49c4e)
ryanjulian pushed a commit that referenced this pull request Nov 22, 2019
@mergify @ryanjulian
Doc: renamed "source activate" (#1056) (#1064) (#1066)
7a92eee 
renamed "source activate" -> "conda activate"
In conda 4.4, the way to activate an environment was changed this way.

(cherry picked from commit 7f49c4e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryanjulian ryanjulian ryanjulian approved these changes

@nish21 nish21 nish21 approved these changes

@yonghyuc yonghyuc Awaiting requested review from yonghyuc

Assignees

No one assigned

Labels

documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Maltimore @ryanjulian @nish21 @naeioi