Skip to content

Use the right env variable for .bash_rc#560

Merged
ryanjulian merged 1 commit intomasterfrom
fix_setup_linux
Mar 6, 2019
Merged

Use the right env variable for .bash_rc#560
ryanjulian merged 1 commit intomasterfrom
fix_setup_linux

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Mar 5, 2019

The variable BASH_PROF is not defined by setup_linux.sh, causing
problems when attempting to append a string to the file path that should
be in BASH_PROF, which expands to nothing.
The right variable to use is BASH_RC.

@ghost ghost added the bug Something isn't working label Mar 5, 2019
@ghost ghost self-assigned this Mar 5, 2019
@ghost ghost requested review from CatherineSue, gautams3 and naeioi March 5, 2019 23:17
@ghost ghost self-requested a review as a code owner March 5, 2019 23:17
The variable BASH_PROF is not defined by setup_linux.sh, causing
problems when attempting to append a string to the file path that should
be in BASH_PROF, which expands to nothing.
The right variable to use is BASH_RC.
@ghost ghost force-pushed the fix_setup_linux branch from 0d660dc to b31e6a0 Compare March 5, 2019 23:20
@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 5, 2019

Tested on a fresh installation of Ubuntu 16.04

Copy link
Copy Markdown
Member

@ryanjulian ryanjulian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make backport PRs as well

@ghost ghost mentioned this pull request Mar 5, 2019
@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 5, 2019

I did, only v2019.10 applies for this one

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 5, 2019

Codecov Report

Merging #560 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #560      +/-   ##
==========================================
+ Coverage   58.34%   58.37%   +0.03%     
==========================================
  Files         135      135              
  Lines        9159     9159              
  Branches     1361     1361              
==========================================
+ Hits         5344     5347       +3     
+ Misses       3431     3421      -10     
- Partials      384      391       +7
Impacted Files Coverage Δ
garage/tf/policies/categorical_gru_policy.py 80% <0%> (ø) ⬆️
...arage/tf/samplers/off_policy_vectorized_sampler.py 71.79% <0%> (ø) ⬆️
garage/misc/krylov.py 20% <0%> (ø) ⬆️
garage/sampler/stateful_pool.py 53.78% <0%> (ø) ⬆️
garage/tf/policies/gaussian_lstm_policy.py 78.83% <0%> (ø) ⬆️
garage/tf/policies/gaussian_gru_policy.py 78.67% <0%> (ø) ⬆️
garage/tf/policies/categorical_lstm_policy.py 79.83% <0%> (ø) ⬆️
garage/misc/special.py 40.9% <0%> (+3.03%) ⬆️
.../exploration_strategies/epsilon_greedy_strategy.py 96.29% <0%> (+3.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3c9c48...b31e6a0. Read the comment docs.

@ryanjulian
Copy link
Copy Markdown
Member

i didn't see a backport for v2018.10?

@ryanjulian ryanjulian merged commit 57904ca into master Mar 6, 2019
@ryanjulian ryanjulian deleted the fix_setup_linux branch March 6, 2019 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants