Use the right env variable for .bash_rc#560
Merged
ryanjulian merged 1 commit intomasterfrom Mar 6, 2019
Merged
Conversation
The variable BASH_PROF is not defined by setup_linux.sh, causing problems when attempting to append a string to the file path that should be in BASH_PROF, which expands to nothing. The right variable to use is BASH_RC.
Author
|
Tested on a fresh installation of Ubuntu 16.04 |
ryanjulian
approved these changes
Mar 5, 2019
Member
ryanjulian
left a comment
There was a problem hiding this comment.
Please make backport PRs as well
Author
|
I did, only v2019.10 applies for this one |
Codecov Report
@@ Coverage Diff @@
## master #560 +/- ##
==========================================
+ Coverage 58.34% 58.37% +0.03%
==========================================
Files 135 135
Lines 9159 9159
Branches 1361 1361
==========================================
+ Hits 5344 5347 +3
+ Misses 3431 3421 -10
- Partials 384 391 +7
Continue to review full report at Codecov.
|
ryanjulian
approved these changes
Mar 6, 2019
Member
|
i didn't see a backport for v2018.10? |
naeioi
approved these changes
Mar 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variable BASH_PROF is not defined by setup_linux.sh, causing
problems when attempting to append a string to the file path that should
be in BASH_PROF, which expands to nothing.
The right variable to use is BASH_RC.