Make the experiment wrapper a module#586
Merged
ryanjulian merged 1 commit intomasterfrom Mar 19, 2019
Merged
Conversation
This makes it easier to use garage as a library. It makes the experiment wrapper script available inside the garage package path. To avoid name collisions, this PR also renames the experiment wrapper from `run_experiment.py` to `experiment_wrapper.py`. Some hacky changes to garage.experiment are necessary to make this work, but we will be deleting that module (and this wrapper) ASAP.
Codecov Report
@@ Coverage Diff @@
## master #586 +/- ##
==========================================
- Coverage 59.23% 58.38% -0.86%
==========================================
Files 139 140 +1
Lines 9045 9177 +132
Branches 1321 1341 +20
==========================================
Hits 5358 5358
- Misses 3303 3435 +132
Partials 384 384
Continue to review full report at Codecov.
|
ghost
approved these changes
Mar 19, 2019
naeioi
approved these changes
Mar 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier to use garage as a library. It makes the
experiment wrapper script available inside the garage package path.
To avoid name collisions, this PR also renames the experiment wrapper
from
run_experiment.pytoexperiment_wrapper.py.Some hacky changes to garage.experiment are necessary to make this
work, but we will be deleting that module (and this wrapper) ASAP.