Conversation
Codecov Report
@@ Coverage Diff @@
## master #677 +/- ##
==========================================
+ Coverage 64.08% 64.62% +0.53%
==========================================
Files 159 161 +2
Lines 9770 9924 +154
Branches 1293 1303 +10
==========================================
+ Hits 6261 6413 +152
- Misses 3182 3183 +1
- Partials 327 328 +1
Continue to review full report at Codecov.
|
ryanjulian
changed the title
ryanjulian
reviewed
May 23, 2019
| @@ -0,0 +1,295 @@ | |||
| """GaussianLSTMPolicy with GaussianLSTMModel.""" | |||
| from akro.tf import Box | |||
ryanjulian
reviewed
May 23, 2019
ryanjulian
reviewed
May 23, 2019
ryanjulian
reviewed
May 23, 2019
ryanjulian
reviewed
May 23, 2019
ryanjulian
reviewed
May 23, 2019
ryanjulian
approved these changes
May 23, 2019
ahtsan
force-pushed
the
gaussian_lstm
branch
6 times, most recently
from
161c2fb to
d20932e
Compare
zhanpenghe
reviewed
May 28, 2019
ryanjulian
reviewed
May 29, 2019
|
|
||
| Returns: | ||
| action (numpy.ndarray): Predicted action. | ||
| agent_info (dict[numpy.ndarray]): Mean and log std of the |
Member
There was a problem hiding this comment.
maybe be explicit about the contents of the dict, e.g.
https://github.com/rlworkgroup/garage/blob/master/src/garage/tf/algos/batch_polopt.py#L85
ryanjulian
reviewed
May 29, 2019
|
|
||
| Returns: | ||
| actions (numpy.ndarray): Predicted actions. | ||
| agent_infos (dict[numpy.ndarray]): Mean and log std of the |
Member
There was a problem hiding this comment.
be explicit about keys in the dict https://github.com/rlworkgroup/garage/blob/master/src/garage/tf/algos/batch_polopt.py#L85
ryanjulian
reviewed
May 29, 2019
|
|
||
| Returns: | ||
| action (numpy.ndarray): Predicted action. | ||
| agent_info (dict[numpy.ndarray]): Mean and log std of the |
Member
There was a problem hiding this comment.
CatherineSue
approved these changes
May 30, 2019
Member
|
Can you please make it multi layer recurrent? Single layer sometimes does not work well for hard problem.. |
Contributor
Author
|
@zhanpenghe I think another PR will be more appropriate. |
Member
|
File an issue then. |
cheng-kevin
pushed a commit
that referenced
this pull request
Jun 3, 2019
This PR refactored GaussianLSTMPolicy with garage.tf.models.Model. It added two classes: GaussianLSTMModel and GaussianLSTMPolicyWithModel.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added GaussianLSTMModel and GaussianLSTMPolicyWithModel.
Added test for PPO with GaussianLSTMPolicyWithModel.
Apart from testing functionality of GaussianLSTMPolicyWithModel
in test_gaussian_lstm_policy_with_model.py, transitions from the
old policy (GaussianLSTMPolicy) to the new policy
(GaussianLSTMPolicyWithModel) are also tested in
test_gaussian_lstm_policy_with_model_transit.py, to make sure
they have the same API.