feat(Subscriptions) add subscriptions#672
Merged
Merged
Conversation
Closed
25b3a75 to
f27cf09
Compare
37120e8 to
41f96e5
Compare
Owner
Author
|
Feature-wise I think this is ready, but as I write the docs, I think the API can be better. Something more ... object-oriented 🙀 |
6ce1dc0 to
2c011f6
Compare
…n methods to hash
feat(Query::Result) add a first-class result object
…er -> Schema#subscriptions
5a92409 to
dce218f
Compare
Owner
Author
|
Working on an ActionCable client rmosolgo/graphql-ruby-client#2 |
|
@rmosolgo Not quite sure what the status of subscription support is at this point. Would I be able to pull the 1.7.0 branch to start implementing subscriptions now? |
Owner
Author
|
@blevine not yet, i'm hoping to merge this into 1.7 today |
Owner
Author
|
Here goes nothin! Feel free to take the 1.7 branch for a spin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's support GraphQL Subscriptions in Ruby!
Some library changes are required:
commentAddedis triggered, the root object is theCommentprovided by the application.)Query::Resultto simplify re-evaluation feat(Query::Result) add a first-class result object #898My implementation has made an assumption about how root fields map to application events:
Is this sufficient for capturing the "unit of subscription"? Or does it miss some cases?
See the guides in this PR for documentation.
Working demo: https://gist.github.com/rmosolgo/ba31acf93f07f8007d99ba365a662d8f