Fix layout issue where MarkerViews disappear#4212
Open
scharron wants to merge 1 commit into
Open
Conversation
When width = 0 and height = 0, View has no dimension yet. Wait for the next layout before addViewAnnotation
scharron
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
scharron
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a guard to avoid creating marker annotation options when the underlying view hasn’t been laid out yet (width/height = 0), addressing a reported rendering issue.
Changes:
- Early-return when the marker view has zero width/height to wait for a subsequent layout.
- Adds an inline reference to the GitHub issue describing the problem.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+122
to
+128
|
|
||
| if (view.width == 0 || view.height == 0) { | ||
| // Fixes https://github.com/rnmapbox/maps/issues/4206 | ||
| // Wait for the next layout via onLayoutChange | ||
| return | ||
| } | ||
|
|
| mMapView?.offscreenAnnotationViewContainer?.removeView(view) | ||
| } | ||
|
|
||
|
|
Comment on lines
+122
to
+128
|
|
||
| if (view.width == 0 || view.height == 0) { | ||
| // Fixes https://github.com/rnmapbox/maps/issues/4206 | ||
| // Wait for the next layout via onLayoutChange | ||
| return | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
width = 0andheight = 0, sometimesViewhas no dimension yet. Wait for the next layout beforeaddViewAnnotationDescription
Fixes #4206
Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)