Skip to content

chore: update temporal protos#69

Closed
rustatian wants to merge 2 commits into
masterfrom
v4
Closed

chore: update temporal protos#69
rustatian wants to merge 2 commits into
masterfrom
v4

Conversation

@rustatian

@rustatian rustatian commented Apr 13, 2026

Copy link
Copy Markdown
Member

Reason for This PR

  • Temporal protos sync.

Description of Changes

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Summary by CodeRabbit

  • Chores
    • Updated Go toolchain to version 1.25.0 with dependency upgrades for stability and security improvements.
    • Updated third-party API integration to the latest version.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian self-assigned this Apr 13, 2026
Copilot AI review requested due to automatic review settings April 13, 2026 08:51
@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Apr 13, 2026
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@coderabbitai

coderabbitai Bot commented Apr 13, 2026

Copy link
Copy Markdown

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

Updated the Go language version from 1.24 to 1.25 and removed toolchain pinning in go.mod. Bumped multiple direct dependencies (Temporal API, Zap logging, gRPC, Protocol Buffers) and indirect dependencies (golang.org/x packages, Google genproto packages) to newer versions. Advanced the third_party/api submodule pointer to a newer commit.

Changes

Cohort / File(s) Summary
Go Module Updates
go.mod
Upgraded Go language version to 1.25.0, removed toolchain directive, and bumped direct dependencies (go.temporal.io/api, go.uber.org/zap, google.golang.org/grpc, google.golang.org/protobuf) and indirect dependencies (golang.org/x/net, golang.org/x/sys, golang.org/x/text, google.golang.org/genproto/*) to newer versions.
Submodule References
third_party/api
Updated git submodule commit pointer to include newer third-party API code.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested labels

C-future-compatibility

Suggested reviewers

  • wolfy-j

Poem

🐰 With Go 1.25 and versions new,
Dependencies dance in vibrant hue,
Submodules leap to futures bright,
A rabbit hops—compatibility's right! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating Temporal protocol buffers, which is clearly reflected in the submodule update and supporting dependency changes.
Description check ✅ Passed The description includes all required template sections with substantive content: clear reasoning (proto sync), specific change description (version reference), license acceptance, and completed checklist items.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch v4
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch v4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Syncs this module’s Temporal API protos and related Go dependencies to match go.temporal.io/api v1.62.8.

Changes:

  • Bump go.temporal.io/api to v1.62.8 and update transitive deps (gRPC, genproto, OTel, etc.).
  • Regenerate Temporal protobuf Go bindings, adding new messages/enums/fields (e.g., worker commands/results, namespace limits/capabilities, compute config types).
  • Update module Go version metadata in go.mod.

Reviewed changes

Copilot reviewed 27 out of 31 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
go.mod Updates required module versions and Go version metadata.
go.sum Records new/updated dependency checksums after the Temporal API bump.
build/temporal/api/worker/v1/message.pb.go Regenerated worker protos (adds drivers, worker list info, worker commands/results).
build/temporal/api/taskqueue/v1/message.pb.go Regenerated taskqueue protos (comment/doc updates).
build/temporal/api/schedule/v1/message.pb.go Regenerated schedule protos (comment/doc updates).
build/temporal/api/protometa/v1/annotations.pb.go Adds regenerated protometa annotations (new file).
build/temporal/api/operatorservice/v1/request_response.pb.go Regenerated operatorservice protos (adds replication enablement fields).
build/temporal/api/nexusservices/workerservice/v1/request_response.pb.go Adds regenerated nexus worker service protos (new file).
build/temporal/api/nexus/v1/message.pb.go Regenerated nexus protos (failure/capabilities updates and new failure variant).
build/temporal/api/namespace/v1/message.pb.go Regenerated namespace protos (adds limits and new capability flags).
build/temporal/api/failure/v1/message.pb.go Regenerated failure protos (adds identity fields and nexus operation failure comment).
build/temporal/api/errordetails/v1/message.pb.go Regenerated errordetails protos (adds ActivityExecutionAlreadyStartedFailure).
build/temporal/api/enums/v1/workflow.pb.go Regenerated workflow enums (adds PAUSED status and new versioning enums/docs).
build/temporal/api/enums/v1/task_queue.pb.go Regenerated task queue enums (clarifies UNSPECIFIED semantics).
build/temporal/api/enums/v1/failed_cause.pb.go Regenerated failed-cause enums (adds payload-too-large and worker-deployment-limits causes).
build/temporal/api/enums/v1/event_type.pb.go Regenerated event types (adds paused/unpaused/time-skipping transitioned events).
build/temporal/api/enums/v1/deployment.pb.go Regenerated deployment enums (adds CREATED status; doc cleanup).
build/temporal/api/enums/v1/activity.pb.go Adds regenerated activity enums (new file).
build/temporal/api/deployment/v1/message.pb.go Regenerated deployment protos (adds compute config, inherited auto-upgrade info, timestamps).
build/temporal/api/compute/v1/scaler.pb.go Adds regenerated compute scaler proto (new file).
build/temporal/api/compute/v1/provider.pb.go Adds regenerated compute provider proto (new file).
build/temporal/api/compute/v1/config.pb.go Adds regenerated compute config protos (new file).
build/temporal/api/common/v1/message.pb.go Regenerated common protos (adds Principal and external payload details).
build/temporal/api/command/v1/message.pb.go Regenerated command protos (adds timeouts, versioning behavior, deprecations).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread go.mod
go 1.24.0

toolchain go1.24.2
go 1.25.0

Copilot AI Apr 13, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description only mentions syncing Temporal protos, but this change also bumps the module Go version to 1.25.0 and drops the previously pinned toolchain. If this is intentional, it should be called out explicitly (and/or kept consistent with prior toolchain pinning) because it affects consumers’ required Go version and build reproducibility.

Copilot uses AI. Check for mistakes.
// task types.
TaskQueueTypes []v1.TaskQueueType `protobuf:"varint,1,rep,packed,name=task_queue_types,json=taskQueueTypes,proto3,enum=temporal.api.enums.v1.TaskQueueType" json:"task_queue_types,omitempty"`
// Stores instructions for a worker control plane controller how to respond
// to worker lifeycle events.

Copilot AI Apr 13, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in comment: "lifeycle" should be "lifecycle".

Suggested change
// to worker lifeycle events.
// to worker lifecycle events.

Copilot uses AI. Check for mistakes.
// Workers that comprise a WorkerDeployment.
type ComputeScaler struct {
state protoimpl.MessageState `protogen:"open.v1"`
// Type of the compute scaler. this string is implementation-specific and

Copilot AI Apr 13, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar/capitalization in comment: start of sentence should be "This string" (capital T).

Suggested change
// Type of the compute scaler. this string is implementation-specific and
// Type of the compute scaler. This string is implementation-specific and

Copilot uses AI. Check for mistakes.
Comment on lines +631 to +635
// The workflow's Target Version is the Current Version of its Task Queue, or, if the
// Task Queue has a Ramping Version with non-zero Ramp Percentage `P`, the workflow's Target
// Version has a P% chance of being the Ramping Version. Whether a workflow falls into the
// Ramping group depends on its Workflow ID and and the Ramp Percentage.
//

Copilot AI Apr 13, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in comment: duplicated word "and and".

Copilot uses AI. Check for mistakes.
Comment on lines +647 to +651
// The workflow's Target Version is the Current Version of its Task Queue, or, if the
// Task Queue has a Ramping Version with non-zero Ramp Percentage `P`, the workflow's Target
// Version has a P% chance of being the Ramping Version. Whether a workflow falls into the
// Ramping group depends on its Workflow ID and and the Ramp Percentage.
//

Copilot AI Apr 13, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in comment: duplicated word "and and".

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants