Conversation
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughUpdated the Go language version from 1.24 to 1.25 and removed toolchain pinning in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Syncs this module’s Temporal API protos and related Go dependencies to match go.temporal.io/api v1.62.8.
Changes:
- Bump
go.temporal.io/apitov1.62.8and update transitive deps (gRPC, genproto, OTel, etc.). - Regenerate Temporal protobuf Go bindings, adding new messages/enums/fields (e.g., worker commands/results, namespace limits/capabilities, compute config types).
- Update module Go version metadata in
go.mod.
Reviewed changes
Copilot reviewed 27 out of 31 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates required module versions and Go version metadata. |
| go.sum | Records new/updated dependency checksums after the Temporal API bump. |
| build/temporal/api/worker/v1/message.pb.go | Regenerated worker protos (adds drivers, worker list info, worker commands/results). |
| build/temporal/api/taskqueue/v1/message.pb.go | Regenerated taskqueue protos (comment/doc updates). |
| build/temporal/api/schedule/v1/message.pb.go | Regenerated schedule protos (comment/doc updates). |
| build/temporal/api/protometa/v1/annotations.pb.go | Adds regenerated protometa annotations (new file). |
| build/temporal/api/operatorservice/v1/request_response.pb.go | Regenerated operatorservice protos (adds replication enablement fields). |
| build/temporal/api/nexusservices/workerservice/v1/request_response.pb.go | Adds regenerated nexus worker service protos (new file). |
| build/temporal/api/nexus/v1/message.pb.go | Regenerated nexus protos (failure/capabilities updates and new failure variant). |
| build/temporal/api/namespace/v1/message.pb.go | Regenerated namespace protos (adds limits and new capability flags). |
| build/temporal/api/failure/v1/message.pb.go | Regenerated failure protos (adds identity fields and nexus operation failure comment). |
| build/temporal/api/errordetails/v1/message.pb.go | Regenerated errordetails protos (adds ActivityExecutionAlreadyStartedFailure). |
| build/temporal/api/enums/v1/workflow.pb.go | Regenerated workflow enums (adds PAUSED status and new versioning enums/docs). |
| build/temporal/api/enums/v1/task_queue.pb.go | Regenerated task queue enums (clarifies UNSPECIFIED semantics). |
| build/temporal/api/enums/v1/failed_cause.pb.go | Regenerated failed-cause enums (adds payload-too-large and worker-deployment-limits causes). |
| build/temporal/api/enums/v1/event_type.pb.go | Regenerated event types (adds paused/unpaused/time-skipping transitioned events). |
| build/temporal/api/enums/v1/deployment.pb.go | Regenerated deployment enums (adds CREATED status; doc cleanup). |
| build/temporal/api/enums/v1/activity.pb.go | Adds regenerated activity enums (new file). |
| build/temporal/api/deployment/v1/message.pb.go | Regenerated deployment protos (adds compute config, inherited auto-upgrade info, timestamps). |
| build/temporal/api/compute/v1/scaler.pb.go | Adds regenerated compute scaler proto (new file). |
| build/temporal/api/compute/v1/provider.pb.go | Adds regenerated compute provider proto (new file). |
| build/temporal/api/compute/v1/config.pb.go | Adds regenerated compute config protos (new file). |
| build/temporal/api/common/v1/message.pb.go | Regenerated common protos (adds Principal and external payload details). |
| build/temporal/api/command/v1/message.pb.go | Regenerated command protos (adds timeouts, versioning behavior, deprecations). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| go 1.24.0 | ||
|
|
||
| toolchain go1.24.2 | ||
| go 1.25.0 |
There was a problem hiding this comment.
The PR description only mentions syncing Temporal protos, but this change also bumps the module Go version to 1.25.0 and drops the previously pinned toolchain. If this is intentional, it should be called out explicitly (and/or kept consistent with prior toolchain pinning) because it affects consumers’ required Go version and build reproducibility.
| // task types. | ||
| TaskQueueTypes []v1.TaskQueueType `protobuf:"varint,1,rep,packed,name=task_queue_types,json=taskQueueTypes,proto3,enum=temporal.api.enums.v1.TaskQueueType" json:"task_queue_types,omitempty"` | ||
| // Stores instructions for a worker control plane controller how to respond | ||
| // to worker lifeycle events. |
There was a problem hiding this comment.
Typo in comment: "lifeycle" should be "lifecycle".
| // to worker lifeycle events. | |
| // to worker lifecycle events. |
| // Workers that comprise a WorkerDeployment. | ||
| type ComputeScaler struct { | ||
| state protoimpl.MessageState `protogen:"open.v1"` | ||
| // Type of the compute scaler. this string is implementation-specific and |
There was a problem hiding this comment.
Grammar/capitalization in comment: start of sentence should be "This string" (capital T).
| // Type of the compute scaler. this string is implementation-specific and | |
| // Type of the compute scaler. This string is implementation-specific and |
| // The workflow's Target Version is the Current Version of its Task Queue, or, if the | ||
| // Task Queue has a Ramping Version with non-zero Ramp Percentage `P`, the workflow's Target | ||
| // Version has a P% chance of being the Ramping Version. Whether a workflow falls into the | ||
| // Ramping group depends on its Workflow ID and and the Ramp Percentage. | ||
| // |
There was a problem hiding this comment.
Typo in comment: duplicated word "and and".
| // The workflow's Target Version is the Current Version of its Task Queue, or, if the | ||
| // Task Queue has a Ramping Version with non-zero Ramp Percentage `P`, the workflow's Target | ||
| // Version has a P% chance of being the Ramping Version. Whether a workflow falls into the | ||
| // Ramping group depends on its Workflow ID and and the Ramp Percentage. | ||
| // |
There was a problem hiding this comment.
Typo in comment: duplicated word "and and".
Reason for This PR
Description of Changes
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).CHANGELOG.md.Summary by CodeRabbit