Skip to content

Fix for Insecure Temporary File Creation #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flemming-n-larsen merged 2 commits into from
May 13, 2025
Merged

Fix for Insecure Temporary File Creation #68

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
964b10f
Fix for Insecure Temporary File Creation
simei2k May 10, 2025
1638298
Added missing imports for RecordManager, formatted the createTempFile…
flemming-n-larsen May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 21 additions & 16 deletions robocode.battle/src/main/java/net/sf/robocode/recording/RecordManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
import net.sf.robocode.battle.snapshot.TurnSnapshot;
import net.sf.robocode.io.FileUtil;
import net.sf.robocode.io.Logger;
import static net.sf.robocode.io.Logger.logError;

import net.sf.robocode.serialization.*;
import net.sf.robocode.settings.ISettingsManager;
import net.sf.robocode.version.IVersionManager;
Expand All @@ -29,6 +27,8 @@
import java.io.*;
import java.nio.charset.Charset;
import java.nio.charset.StandardCharsets;
import java.security.AccessController;
import java.security.PrivilegedAction;
import java.text.SimpleDateFormat;
import java.util.Calendar;
import java.util.List;
Expand All @@ -37,6 +37,8 @@
import java.util.zip.ZipInputStream;
import java.util.zip.ZipOutputStream;

import static net.sf.robocode.io.Logger.logError;


/**
* @author Pavel Savara (original)
Expand Down Expand Up @@ -111,22 +113,25 @@ public void detachRecorder() {
}

private void createTempFile() {
try {
if (tempFile == null) {
tempFile = File.createTempFile("robocode-battle-records", ".tmp");
tempFile.deleteOnExit();
} else {
if (!tempFile.delete()) {
Logger.logError("Could not delete temp file");
}
if (!tempFile.createNewFile()) {
throw new Error("Temp file creation failed");
AccessController.doPrivileged((PrivilegedAction<Void>) () -> {
try {
if (tempFile == null) {
tempFile = File.createTempFile("robocode-battle-records", ".tmp");
tempFile.deleteOnExit();
} else {
if (!tempFile.delete()) {
logError("Could not delete temp file");
}
if (!tempFile.createNewFile()) {
throw new Error("Temp file creation failed");
}
}
} catch (IOException e) {
logError(e);
throw new Error("Temp file creation failed", e);
}
} catch (IOException e) {
logError(e);
throw new Error("Temp file creation failed", e);
}
return null;
});
}

void prepareInputStream() {
Expand Down