Skip to content

Fix Integer Overflow Vulnerability in Buffer Write Method #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flemming-n-larsen merged 3 commits into from
May 13, 2025
+11 −3
Merged

Fix Integer Overflow Vulnerability in Buffer Write Method #70

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ca52e3
Fix Integer Overflow Vulnerability in Buffer Write Method
simei2k May 10, 2025
9f61617
Removal of misplaced insertion of the same write() method before the …
flemming-n-larsen May 13, 2025
9787e2c
Formatted write() method
flemming-n-larsen May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions robocode.host/src/main/java/net/sf/robocode/host/io/RobotFileOutputStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,16 +46,24 @@ public final void write(byte[] b) throws IOException {

@Override
public final void write(byte[] b, int off, int len) throws IOException {
if (len < 0) {
throw new IndexOutOfBoundsException();
// Sanity check
if (b == null) {
throw new NullPointerException();
}

// Comprehensive bounds checking to prevent integer overflow
if (off < 0 || len < 0 || len > b.length || off > b.length - len) {
throw new ArrayIndexOutOfBoundsException();
}

try {
fileSystemManager.checkQuota(len);
super.write(b, off, len);
} catch (IOException e) {
try {
close();
} catch (IOException ignored) {}
} catch (IOException ignore) {
}
throw e;
}
}
Expand Down