fix: complete review type flag

[mariusvniekerk]

Summary

• add shell completion for roborev review --type
• complete security and design without file fallback
• add regression coverage for review type flag completion

Validation

• go fmt ./...
• go vet ./...
• go test ./...

[roborev-ci]

roborev: Combined Review (1f93e36)

High: Adds --type shell completion, but one compile-blocking issue was reported.

High

• cmd/roborev/completions.go lines 33-34; cmd/roborev/completions_test.go line 19
  RegisterFlagCompletionFunc expects a callback returning ([]string, cobra.ShellCompDirective), but the change reportedly uses []cobra.Completion. That will fail to compile with spf13/cobra.
  Fix: return []string instead, casting review type constants with string(...) if they are custom types.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
cmd/roborev/completions.go	60.00%	1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!