1174 zipkin exporter v1 thrift support#2
Open
robwknox wants to merge 27 commits into1173_zipkin_exporter_v1_json_support_fixfrom
Open
1174 zipkin exporter v1 thrift support#2robwknox wants to merge 27 commits into1173_zipkin_exporter_v1_json_support_fixfrom
robwknox wants to merge 27 commits into1173_zipkin_exporter_v1_json_support_fixfrom
Conversation
…4_zipkin_exporter_v1_thrift_support
…exporter_v1_thrift_support
…exporter_v1_thrift_support
…ncation with thrift-based exporters
…exporter_v1_thrift_support
…exporter_v1_thrift_support
…exporter_v1_thrift_support
…exporter_v1_thrift_support
…exporter_v1_thrift_support
…exporter_v1_thrift_support
…exporter_v1_thrift_support
…exporter_v1_thrift_support
…kin_exporter_v1_thrift_support
…kin_exporter_v1_thrift_support
…kin_exporter_v1_thrift_support
…kin_exporter_v1_thrift_support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the Zipkin Exporter v1 API thrift format.
Important note on Trace and Span IDs
Thrift only supports signed integers (max 64 bits). This results in the Zipkin Thrift API having type definitions of:
The default OTEL
RandomIdsGeneratorclass generates unsigned integers of 64-bits (span) and 128-bits (trace). This results in default behavior of integer overflow during encoding ~50% of the time for Span IDs and ~75% for Trace IDs. Not a practical situation so the code provides two solutionsThriftRandomIdsGeneratorhas been provided to override the default OTEL generator. This slightly reduces the size of the generated IDs (63-bit for span / 126-bit for trace) in order to enusre they will fit into the thrift data types.Fixes open-telemetry#1174
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: