Download a single chunk if the server does not support the Range header#10
Merged
rogerfar merged 1 commit intoMay 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9. See also rogerfar/rdt-client/issues/782
I've tested with with
rdt-clientdownloading a TorBox zip (and regular downloads from AD, which setsAccept-Ranges).Currently, we just assume that every server respects the
Rangeheader. But not all do. If they don't we end up downloading the whole file for every chunk we want to download.This PR adds a step when we perform the HEAD request to get the
Content-Lengthto also check if the server supports theRangeheader. Servers should1 put theAccept-Ranges: bytesheader in the HEAD response if they support theRangeheader on the subsequent GET requests.Footnotes
TorBox don't set this header for their non-zipped download links. I've reached out to them via discord to see if they can set it. AD, DL, PM and RD all set this header correctly. ↩