Optimize ternary transpilation for assignments#1341
Merged
TwitchBronBron merged 4 commits intomasterfrom Nov 1, 2024
Merged
Conversation
Contributor
|
Hey there! I just built a new temporary npm package based on 7fee5a1. You can download it here or install it by running the following command: npm install https://github.com/rokucommunity/brighterscript/releases/download/v0.0.0-packages/brighterscript-0.67.8-ternary-to-if-statement.20241121134906.tgz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever a ternary expression is on the right-hand-side of an assignment, dottedSet, or indexedSet statement, we can transpile the entire thing to an
ifstatement instead which improves performance significantly (should be identical to handwritten non-ternary code).This PR adds this
ifstatement transpiling for all of the following situations:a = true ? 1 : 2m.a = true ? 1 : 2m["a"] = true ? 1 : 2+=,-=, etc...)size += true ? 1 : 2a = (((true ? 1 : 2)))a = true ? (false ? 1 : 2) : 3These are explicit cases, so any situation other than these will be transpiled according to the existing rules (basic and scope safe)
Simple example:
becomes this:
Nested example:
becomes this:
This benchmark shows a significant improvement in performace