Language Server Crash Fix#1353
Merged
TwitchBronBron merged 2 commits intorokucommunity:masterfrom Nov 25, 2024
Merged
Conversation
Contributor
|
What does the device do if you try to extend yourself? I assume a compile error? |
TwitchBronBron
approved these changes
Nov 25, 2024
Member
TwitchBronBron
left a comment
TwitchBronBron
left a comment
There was a problem hiding this comment.
Nice! I'll go ahead and merge this for now, you can feel free to open another PR with the additional fixes if you find the time to work on them. :)
Contributor
Author
I'll get that info and open as an issue (or a PR if I can identify a fix)! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, apparently this property is deprecated now
Additional Work Remaining
Second, if you do something super dumb like:
Profitcrashes!This causes an infinite loop and a lot of lang. server crashes. I'll look further at this later to see where we can maybe prevent this from crashing and flag the error to the user. Right now there's no feedback besides a ton of crashes