Fixed getClosestExpression bug to return undefined when position not found#1433
Merged
TwitchBronBron merged 1 commit intomasterfrom Mar 20, 2025
Conversation
…on in a file in position was missing
TwitchBronBron
changed the title
TwitchBronBron
approved these changes
Mar 20, 2025
TwitchBronBron
deleted the
bugfix/issue-with-closest-epression-with-missing-position
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug in
BrsFile.getClosestExpression()that was returning the last expression in the AST when given an undefined position. Now we returnundefinedif the position or position.line is undefined, which should make more sense and also save a little processing time because we can exit early instead of traversing the entire AST tree