Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
program.getFile()to support absolute and relative paths. This more closely aligns with the v1 implementation (excluding support currently for havingpkg:/prefixes forpkgPathlike v1 has);getFileByPathAbsoluteandgetFileByPkgPathin favor of usinggetFilefor both. (they still work, but typescript will show them in strikethrough)getFilesByPkgPathin favor of `getFiles (same point as above)ProgramassignFileandunassignFilemethods to clean up that logic (aligns with v1 implementation).getFirstScopeForFilefunction to find the first scope for a fileFileLinkinterface into interfaces since it's not really aProgram-specific interface.