Merged
Conversation
Contributor
|
Plenty of typos in the comments but cool! |
Member
Author
|
@elsassph I fixed the typos, and found/fixed another memory leak! |
TwitchBronBron
force-pushed
the
fix-memory-leak
branch
from
fdfbc83 to
58da242
Compare
Member
Author
|
As a result of this fix (and increasing my nodejs ram limit to 8gig to allow the benchmark to finish), we should see significant performance boosts?
|
triwav
approved these changes
Feb 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a memory leak when replacing files.
Before
After