Fix logger.time() not returning accurate timings#532
Merged
TwitchBronBron merged 2 commits intorokucommunity:masterfrom Mar 8, 2022
luis-j-soares:fix/incorrect-logger-time
Merged
Fix logger.time() not returning accurate timings#532TwitchBronBron merged 2 commits intorokucommunity:masterfrom luis-j-soares:fix/incorrect-logger-time
TwitchBronBron merged 2 commits intorokucommunity:masterfrom
luis-j-soares:fix/incorrect-logger-time
Conversation
Member
|
Oh, good catch! |
Member
|
@luis-soares-sky this was included in release v0.45.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While diagnosing why the compiler is taking so long in our project, we noticed that the reported time is not correct.
After debugging a bit, I found that
stopwatch.stop()was called right afteraction(...), which doesn't work for async methods (which "Parsing files"/loadAllFilesASTis).Moving the stop inside the
donecallback seems to do the trick.