Flag usage of undefined variables#631
Merged
TwitchBronBron merged 14 commits intomasterfrom Jul 12, 2022
Merged
Conversation
chrisdp
approved these changes
Jun 15, 2022
chrisdp
approved these changes
Jul 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR finds usage of all variables that have not been defined.
This is overlapping functionality with bslint's
LINT1001rule, but we need this to do additional logic, and it's something a compiler should do natively anyway. LINT1001 is slightly superior in that it also detects "used before defined" errors, but they are not flagged that way in bslint and are included in the same LINT1001 bucket.This adds basic symbol table support as well, just for name tracking purposes.