Fix injection of duplicate super calls into classes#823
Merged
TwitchBronBron merged 1 commit intorokucommunity:masterfrom Jun 9, 2023
Merged
Conversation
TwitchBronBron
approved these changes
Jun 9, 2023
Member
|
Looks great! Thanks for this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I've encountered the same issue described in this slack thread, which is preventing my team from adopting Rooibos's code coverage feature. It was mentioned in the thread that the current behavior of only looking at the first statement of a constructor in order to find a
supercall may be a bug. Here is my attempt at a fix. I hope it's helpful, please let me know if there are any changes needed to it.