Make component ready on afterScopeCreate#843
Merged
TwitchBronBron merged 1 commit intorokucommunity:masterfrom Jul 14, 2023
iBicha:fix/component-ready-on-scope-event
Merged
Make component ready on afterScopeCreate#843TwitchBronBron merged 1 commit intorokucommunity:masterfrom iBicha:fix/component-ready-on-scope-event
TwitchBronBron merged 1 commit intorokucommunity:masterfrom
iBicha:fix/component-ready-on-scope-event
Conversation
TwitchBronBron
approved these changes
Jul 13, 2023
Member
TwitchBronBron
left a comment
TwitchBronBron
left a comment
There was a problem hiding this comment.
Sweet! I can honestly say I hadn't encountered this before. Nice fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was facing a bug where components were not ready by scope creation.
Also another issue is the dependency graph is not set yet before registering the component.
This makes the scope ready when the event is fired