Install v8-profiler-next on demand instead of being a dependency#854
Merged
TwitchBronBron merged 1 commit intomasterfrom Jul 24, 2023
Merged
Install v8-profiler-next on demand instead of being a dependency#854TwitchBronBron merged 1 commit intomasterfrom
v8-profiler-next on demand instead of being a dependency#854TwitchBronBron merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#833 added the ability to run a profiling session with a single cli flag. However, it also brought with it a dependency on
v8-profiler-next, which requires node-gyp to compile. That's a pain.Since most bsc users won't be profiling the project, this PR moves that behind an on-demand install instead. That should help with nodejs compatibility and reduce npm install issues related to node-gyp.