add noProject flag to bsc so BSConfig.json not expected#868
add noProject flag to bsc so BSConfig.json not expected#868TwitchBronBron merged 7 commits intorokucommunity:masterfrom philanderson888:add-no-project-flag-so-bsconfig-json-not-expected
Conversation
philanderson888
changed the title
philanderson888
changed the title
TwitchBronBron
left a comment
TwitchBronBron
left a comment
There was a problem hiding this comment.
Hey, here are a few suggestions.
If --noProject is present at all, we should disable all project loading, even if the user has supplied --project. That should simplify the logic a bit, and makes logical sense to me
|
Thank you @TwitchBronBron for that clarification - yes I was not sure which way to go, so went for the softer option! Happy to go with the hard stop so if the flag is set, bsconfig.json loading is completely disabled. Happy for you to review the code a second time Thanks All suggestions implemented, just a few changes to comments but other than that as-is as you specified. Please check all code and let me know any faults or amendments, thanks :) |
TwitchBronBron
left a comment
TwitchBronBron
left a comment
There was a problem hiding this comment.
Looks great. Thanks for this!
|
Thanks @TwitchBronBron happy to help Onwards and upwards to the next one! |
2 participants
No description provided.