Add manifest loading from files#942
Merged
TwitchBronBron merged 8 commits intorokucommunity:masterfrom Dec 4, 2023
Merged
Conversation
TwitchBronBron
approved these changes
Dec 4, 2023
Member
TwitchBronBron
left a comment
TwitchBronBron
left a comment
There was a problem hiding this comment.
Looks great! Thanks for your patience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The program is currently set to load a manifest from the project's root. This isn't very flexible, and it causes some issues for projects which generate their manifests in a pre-compile step, i.e.,
bs_constvalues not getting read and causing code blocks to be removed erroneously.This PR tweaks
ProgramBuilder.loadAllFilesAST's logic, to group/filter files and find a manifest in a first pass, then load the manifest into the program, and finally setting typedefs and code files. I've also adjusted the manifest loading to accept a file object, with some slight code refactoring in the mix.