Skip to content

fix(inject): rollup is optional peer dependency - #1272

Closed
milahu wants to merge 1 commit into
rollup:masterfrom
milahu:patch-1
Closed

fix(inject): rollup is optional peer dependency#1272
milahu wants to merge 1 commit into
rollup:masterfrom
milahu:patch-1

Conversation

@milahu

@milahu milahu commented Sep 24, 2022

Copy link
Copy Markdown

Rollup Plugin Name: inject

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

Relevant issues:

Description

this plugin can be used from vite
for example in https://github.com/sodatea/vite-plugin-node-stdlib-browser

in this case, rollup is not installed

this fix should also be applied to other rollup plugins

workaround for pnpm: add this to package.json

{
  "pnpm": {
    "peerDependencyRules": {
      "ignoreMissing": [
        "rollup"
      ]
    }
  }
}

@lukastaegert lukastaegert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Considering your arguments, I added this change to all PRs I just created for Rollup 3 compatibility of plugins, see e.g. #1292. This supersedes your PR, but we can still merge it first if you want the contribution.

@milahu

milahu commented Oct 1, 2022

Copy link
Copy Markdown
Author

thanks : )

This supersedes your PR, but we can still merge it first if you want the contribution.

i dont care

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants