fix(pluginutils): add current working dirctory when pattern starts with one * - #1547
Merged
Conversation
lukastaegert
approved these changes
Aug 2, 2023
lukastaegert
left a comment
lukastaegert
left a comment
Member
There was a problem hiding this comment.
Looks good to me, thanks for your effort!
Collaborator
|
@lukastaegert thoughts on this being a breaking change? result sets will now include more than was there before. could result in unexpected behavior. |
Member
|
I would tend to say that the previous behavior was a bug and very unlikely to be used by anyone, and thus it should not be a new major version. |
Collaborator
|
OK cool. we'll put it through as a patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
pluginutilsThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
relevant: #1538
Description
Currently, if we use a format like
*.jsin theincludeoption of@rollup/plugins, the plugin cannot filter files correctly, I created a minimal reprodution https://stackblitz.com/edit/rollup-repro-dnz5kc?file=rollup.config.js. This PR addresses this problem with the solution described in issue #1538.