Skip to content

chore(repo): update comment to clarify top-level this rewrite - #1888

Merged
shellscape merged 1 commit into
rollup:masterfrom
situ2001:situ/fix-comment-on-cjs-transform
Sep 4, 2025
Merged

chore(repo): update comment to clarify top-level this rewrite#1888
shellscape merged 1 commit into
rollup:masterfrom
situ2001:situ/fix-comment-on-cjs-transform

Conversation

@situ2001

@situ2001 situ2001 commented Aug 2, 2025

Copy link
Copy Markdown
Contributor

Rollup Plugin Name: {name}

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

Update the comment (based on latest logic by #1618) to avoid misleading others in the future.

@situ2001
situ2001 requested a review from shellscape as a code owner August 2, 2025 14:15
@shellscape shellscape changed the title refactor(commonjs): update comment to clarify top-level this rewrite chore(repo): update comment to clarify top-level this rewrite Sep 4, 2025
@shellscape
shellscape merged commit 0862902 into rollup:master Sep 4, 2025
@shellscape

Copy link
Copy Markdown
Collaborator

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants