fix(babel): Pass chunk filename to output plugin transform

[evocateur]

Rollup Plugin Name: @rollup/plugin-babel

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers: N/A

Description

This appears to be an oversight, as the filename is passed at the same place in the input plugin transform Babel options. Without this field, a Babel error including text "Preset /* your preset */ requires a filename to be set when babel is called directly" is thrown when using a custom preset.

[!] (plugin babel) Error: [BABEL] unknown: Preset /* your preset */ requires a filename to be set when babel is called directly,
```
babel.transform(code, { filename: 'file.ts', presets: [/* your preset */] });
```
See https://babeljs.io/docs/en/options#filename for more information.
Error: [BABEL] unknown: Preset /* your preset */ requires a filename to be set when babel is called directly,
```
babel.transform(code, { filename: 'file.ts', presets: [/* your preset */] });
```
See https://babeljs.io/docs/en/options#filename for more information.
    at validateIfOptionNeedsFilename ($PWD/node_modules/@babel/core/lib/config/full.js:274:11)
    at options.overrides.forEach.overrideOptions ($PWD/node_modules/@babel/core/lib/config/full.js:286:52)
    at Array.forEach (<anonymous>)
    at validatePreset ($PWD/node_modules/@babel/core/lib/config/full.js:286:25)
    at loadPresetDescriptor ($PWD/node_modules/@babel/core/lib/config/full.js:293:3)
    at loadPresetDescriptor.next (<anonymous>)
    at recurseDescriptors ($PWD/node_modules/@babel/core/lib/config/full.js:107:30)
    at recurseDescriptors.next (<anonymous>)
    at recurseDescriptors ($PWD/node_modules/@babel/core/lib/config/full.js:128:34)
    at recurseDescriptors.next (<anonymous>)

(stack trace is using @babel/core@7.10.5)

The test is not ideal, but without replicating a huge stack of other Rollup plugins and complicated Babel config, it's unclear how else to regress this in a focused, minimal way. A local edit of the Rollup Babel plugin in node_modules of the offending build does indicate the error is mitigated, however.

[evocateur]

Ooh, I think I figured out the trigger, and it's much simpler than I thought: @babel/preset-typescript is configuring the test field, which is what triggers validateIfOptionNeedsFilename to explode. The workaround probably involves setting a preset option like allExtensions, but at least it promises to make the test here a bit more specific and less brittle.

[evocateur]

Additionally, in a repo where @babel/preset-typescript is not enabled, it looks like a Babel config file with overrides will trip up getBabelOutputPlugin() too:

[!] (plugin babel) Error: Configuration contains string/RegExp pattern, but no filename was passed to Babel
Error: Configuration contains string/RegExp pattern, but no filename was passed to Babel
    at matchPattern ($PWD/node_modules/@babel/core/lib/config/config-chain.js:430:11)
    at patterns.some.pattern ($PWD/node_modules/@babel/core/lib/config/config-chain.js:417:35)
    at Array.some (<anonymous>)
    at matchesPatterns ($PWD/node_modules/@babel/core/lib/config/config-chain.js:417:19)
    at configFieldIsApplicable ($PWD/node_modules/@babel/core/lib/config/config-chain.js:399:10)
    at configIsApplicable ($PWD/node_modules/@babel/core/lib/config/config-chain.js:394:41)
    at forEach ($PWD/node_modules/@babel/core/lib/config/config-chain.js:255:13)
    at Array.forEach (<anonymous>)
    at $PWD/node_modules/@babel/core/lib/config/config-chain.js:252:42
    at Generator.next (<anonymous>)

The .babelrc.js in question:

module.exports = {
    presets: [
        [
            '@babel/preset-env',
            {
                targets: {
                    ie: 11,
                },
            },
        ],
    ],
    overrides: [
        {
            test: [
                './src/stuff.js',
                './src/things/*.js',
            ],
            presets: [
                [
                    '@babel/preset-env',
                    {
                        exclude: ['@babel/plugin-transform-classes'],
                        targets: {
                            node: 'current',
                        },
                    },
                ],
            ],
        },
    ],
};

[Andarist]

This was not implemented on purpose - see rollup/rollup-plugin-babel#333 (comment) . I'm too tired today to analyze this issue as a whole but maybe you could look at the linked comments to see how this applies to your case (or how it doesn't).

[evocateur]

@Andarist Will do, thanks for the pointer!

[evocateur]

Well, turns out I was barking up the wrong tree entirely. Output plugins were not the solution, I needed to pass an array of configs from my rollup.config.js instead so the per-config input plugin could do the right thing w/r/t the supportsStaticESM caller property.

Thanks for your responsiveness!