2.1.0 breaks all typescript builds

[fkleuver]

From one moment to the next, projects using rollup-plugin-typescript2 break after a fresh install without changing anything.

Took me several hours to pinpoint it to this package. 2.0.1 worked fine, the silent upgrade to 2.1.0 however breaks everything.

Minimal repro:

1. git clone https://github.com/fkleuver/rollup-pluginutils-issue
2. cd rollup-pluginutils-issue
3. npm install <- will install 2.0.1
4. .\node_modules\.bin\rollup --c --format cjs

5. npm i rollup-pluginutils@2.1.0 -D
6. .\node_modules\.bin\rollup --c --format cjs

Basically the typescript files don't seem to go through the typescript plugin anymore. The same thing happens for different build configurations, outputs, tsconfigs and whatnot.

Did you even test your changes??

[Rich-Harris]

Did you even test your changes??

Pro-tip: Don't be that guy. It's not in your interests. Bugs happen, test suites don't always catch them, the maintainers fix them, and the world keeps turning. I'm sorry that this piece of free software caused you to lose some time — really, I mean that, I totally get that it's a nuisance when it happens — but being a dick about it doesn't make anything better; it just contributes to maintainer burnout.

[fkleuver]

@Rich-Harris I agree with you on the principle. However, as an author and contributor of FOSS I also try (and expect others, especially if they work on critical pieces) to make every effort to avoid introducing breaking changes. See I didn't lose time working on my own stuff, I lost time working on free software as well. I think we can try and hold each other to higher standards - at the very least do a major version bump if you don't have time to do smoke tests with important packages.

I'm not here complaining about missing features or a bug that has always been there. I'm being a dick about a breaking change being introduced on a minor version - if others are a dick about that to me on one of my projects, I'd think I deserved that. I apologize if I hurt any feelings but I hold my ground and think we should be doing better than this.

[JiriPelnar]

Our angular AOT builds also started to fail today. This time the plugin in use is rollup-plugin-commonjs. After some time spent investigated I managed to localize the most probable cause of the issue to the version of rollup-pluginutils raised from 2.0.1 to 2.1.0. Adding "rollup-pluginutils": "2.0.1" explicitly to package.json solved the issue for me.
The error that is reported by rollup: Error: 'Subject' is not exported by node_modules\rxjs\Subject.js

[fkleuver]

@guybedford Your last commit seems to have fixed the issue. Problem no longer occurring with 2.1.1. Thanks a ton for your prompt response!

[guybedford]

@fkleuver sure, thanks for the test case here, it helped a lot.

It turns out the issue here was a dropped ball between us in testing a dependency upgrade (the fix was 9bb49c4), due to an npm bug at publish time requiring us to ask Rich to publish when he wasn't actively involved in the project - #29 (comment).

Please do be nice to maintainers, and consider donating to projects that you benefit from (https://opencollective.com/rollup). Healthy ecosystems are important.

[fkleuver]

Alright, well considering the silly circumstances of how this slipped in I apologize for the tone. It's the first time I do that and let it be the last time as well.

[Rich-Harris]

@fkleuver Thanks, appreciate it. Glad we could get the issue resolved quickly