Skip to content
This repository was archived by the owner on Aug 4, 2021. It is now read-only.

use Minimatch#match instead of makeRe - #6

Merged
Rich-Harris merged 1 commit into
rollup:masterfrom
leeyeh:fix-minimatch
Jun 7, 2016
Merged

use Minimatch#match instead of makeRe#6
Rich-Harris merged 1 commit into
rollup:masterfrom
leeyeh:fix-minimatch

Conversation

@leeyeh

@leeyeh leeyeh commented May 14, 2016

Copy link
Copy Markdown
Contributor

I'm using the babel plugin with exclude option:

 babel({ runtimeHelpers: true , exclude: ['node_modules/!(axios)/**'] })

However, axios is not transformed.

I did some debugging, and it turns out minimatch has an issue generating the RegExps: isaacs/minimatch#83

This is a quick fix to get it work before the issue got fixed.

@Rich-Harris
Rich-Harris merged commit 1704cb3 into rollup:master Jun 7, 2016
@Rich-Harris

Copy link
Copy Markdown
Contributor

Thanks! Sorry for the slow response – now released as 1.4.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants