fix(docker): use dashes instead of colons in PR build version string#640
Merged
bodji merged 1 commit intoroot-gg:masterfrom Feb 25, 2026
Merged
fix(docker): use dashes instead of colons in PR build version string#640bodji merged 1 commit intoroot-gg:masterfrom
bodji merged 1 commit intoroot-gg:masterfrom
Conversation
Colons in the VERSION string caused tar to interpret the archive filename as a remote host path (e.g. plik-server-1.4-RC4:pr-636:abc is parsed as host:path), breaking the build with "resolve failed".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace colons with dashes in the
VERSIONstring computed by the PR Docker build workflow.Why
Colons in the archive filename (e.g.
plik-server-1.4-RC4:pr-636:58d5275c-linux-arm.tar.gz) causetarto interpret the filename as a remote host path (host:path), failing with"Cannot connect to plik-server-1.4-RC4: resolve failed".Changes
.github/workflows/docker-build-pr.yaml: change VERSION separator from:to-Testing
plik-server-1.4-RC4-pr-636-58d5275c-linux-arm.tar.gzcontains no special characters