fix(webapp): mobile menu separator + light theme polish#720
Merged
fix(webapp): mobile menu separator + light theme polish#720
Conversation
camathieu
changed the title
added 2 commits
March 27, 2026 22:36
The trailing hr in the mobile navigation drawer was rendered whenever
the theme or language pickers were visible, regardless of whether auth was
enabled. Since each picker block already includes its own leading separator,
the trailing one is only needed when there are auth items below it.
Fix: narrow the v-if to isFeatureEnabled('authentication') only.
The light theme backgrounds were using warm mid-grays (#f5f5f5) for both the page and header, making the UI feel slightly dingy. Shift all surface tokens a step lighter and cooler without going full white: - surface-950 (page bg): #f5f5f5 → #fafafa - surface-900 (header bg): #f5f5f5 → #f7f9fb - surface-800 (cards/inputs): #f9f9f9 → #fdfdfd - surface-700 (borders): #d1d5db → #d9dde5 - file-row hover: #f0f1f3 → #f1f3f6
camathieu
force-pushed
the
fix/mobile-menu-separator
branch
from
7de55fb to
157b937
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two small UI polish fixes for the webapp.
Commits
11059d7fix(webapp): remove extra separator in mobile menu when auth is disabledv-ifon the trailing<hr>in the mobile drawer includedshowThemePicker || showLanguagePicker, rendering a stray separator below Language when auth was offisFeatureEnabled('authentication')only7de55fbfix(webapp): brighten and cool light theme surface palette#f5f5f5) for both page and header backgrounds, giving a slightly dingy feelChanges
webapp/src/components/AppHeader.vue: Remove spurious separator after Language picker when auth is disabledwebapp/public/themes/light.css: Nudge surface palette lighter and coolersurface-950(page bg)#f5f5f5#fafafasurface-900(header bg)#f5f5f5#f7f9fbsurface-800(cards/inputs)#f9f9f9#fdfdfdsurface-700(borders)#d1d5db#d9dde5file-row:hover#f0f1f3#f1f3f6Testing
make test-frontend)make lint)