[cling] crash with .Class

[ferdymercury]

Describe the bug

A crash is produced if you type .Class in the ROOT prompt.

===========================================================================
struct std::atomic<_Tp *>
SIZE: (NA) FILE: atomic LINE: -1
List of member variables --------------------------------------------------
root.exe: /opt/root_src/interpreter/llvm/src/tools/clang/include/clang/AST/TypeNodes.def:100: clang::TypeInfo clang::ASTContext::getTypeInfoImpl(const clang::Type*) const: Assertion `!T->isDependentType() && "should not see dependent types here"' failed.

Expected behavior

No crash.

Also, if you type .Class TTree it should only print TTree's class info, not all the list of classes. In analogy to .class TTree vs .class --> EDIT: This part is solved now.

To Reproduce

.Class
or .Class TTree

Setup

   ------------------------------------------------------------------
  | Welcome to ROOT 6.27/01                        https://root.cern |
  | (c) 1995-2021, The ROOT Team; conception: R. Brun, F. Rademakers |
  | Built for linuxx8664gcc on Jan 12 2022, 10:17:19                 |
  | From heads/master@v6-25-01-2870-gdac9b6398d                      |
  | With c++ (Ubuntu 8.4.0-1ubuntu1~18.04) 8.4.0                     |
  | Try '.help', '.demo', '.license', '.credits', '.quit'/'.q'       |
   ------------------------------------------------------------------

Additional context

#10121

[couet]

.class is fine. Should .Class be transformed in .class ?

[ferdymercury]

.class is fine. Should .Class be transformed in .class ?

.Class is the 'extra verbose' option of .class, thus it is printing more information.

[ferdymercury]

Here is the end of the gdb backtrace. It seems like an infinitely recursive loop.

#0  0x00007ffff2d5e3ef in clang::ASTContext::getTypeInfo(clang::Type const*) const () from lib/libCling.so
...
...
...
...
#65370 0x00007ffff2d5e535 in clang::ASTContext::getTypeInfo(clang::Type const*) const () from lib/libCling.so
#65371 0x00007ffff2d5e535 in clang::ASTContext::getTypeInfo(clang::Type const*) const () from lib/libCling.so
#65372 0x00007ffff2d5e535 in clang::ASTContext::getTypeInfo(clang::Type const*) const () from lib/libCling.so
#65373 0x00007ffff2d5e535 in clang::ASTContext::getTypeInfo(clang::Type const*) const () from lib/libCling.so
#65374 0x00007ffff2d5e535 in clang::ASTContext::getTypeInfo(clang::Type const*) const () from lib/libCling.so
#65375 0x00007ffff2d5e535 in clang::ASTContext::getTypeInfo(clang::Type const*) const () from lib/libCling.so
#65376 0x00007ffff2d5e535 in clang::ASTContext::getTypeInfo(clang::Type const*) const () from lib/libCling.so
#65377 0x00007ffff2d6853e in clang::ASTContext::getTypeInfoImpl(clang::Type const*) const () from lib/libCling.so
#65378 0x00007ffff2d5e535 in clang::ASTContext::getTypeInfo(clang::Type const*) const () from lib/libCling.so
#65379 0x00007ffff2d64f55 in clang::ASTContext::getTypeInfoInChars(clang::Type const*) const () from lib/libCling.so
#65380 0x00007ffff2fa1246 in (anonymous namespace)::ItaniumRecordLayoutBuilder::LayoutField(clang::FieldDecl const*, bool) [clone .part.493] ()
   from lib/libCling.so
#65381 0x00007ffff2fa1869 in (anonymous namespace)::ItaniumRecordLayoutBuilder::LayoutFields(clang::RecordDecl const*) ()
   from lib/libCling.so
#65382 0x00007ffff2f9e108 in clang::ASTContext::getASTRecordLayout(clang::RecordDecl const*) const () from lib/libCling.so
#65383 0x00007ffff0adc7bf in cling::(anonymous namespace)::ClassPrinter::DisplayDataMembers(clang::CXXRecordDecl const*, unsigned int) const ()
   from lib/libCling.so
#65384 0x00007ffff0ae10cf in cling::(anonymous namespace)::ClassPrinter::DisplayClassDecl(clang::CXXRecordDecl const*) const ()
   from lib/libCling.so
#65385 0x00007ffff0ae2372 in cling::(anonymous namespace)::ClassPrinter::ProcessDecl(clang::DeclContext::decl_iterator) const ()
   from lib/libCling.so
#65386 0x00007ffff0ae225b in cling::(anonymous namespace)::ClassPrinter::ProcessDecl(clang::DeclContext::decl_iterator) const ()
   from lib/libCling.so
#65387 0x00007ffff0ae287b in cling::DisplayClasses(llvm::raw_ostream&, cling::Interpreter const*, bool) () from lib/libCling.so
#65388 0x00007ffff0ad4d6e in cling::MetaSema::actOnClassCommand(llvm::StringRef) const () from lib/libCling.so
#65389 0x00007ffff0ae7340 in cling::MetaParser::isClassCommand() () from lib/libCling.so
#65390 0x00007ffff0ae77db in cling::MetaParser::isCommand(cling::MetaSema::ActionResult&, cling::Value*) () from lib/libCling.so
#65391 0x00007ffff0ad07d0 in cling::MetaProcessor::process(llvm::StringRef, cling::Interpreter::CompilationResult&, cling::Value*, bool) ()
   from lib/libCling.so
#65392 0x00007ffff081294d in HandleInterpreterException (metaProcessor=0x555556096de0, input_line=0x7fffffffb239 ".Class", compRes=@0x7fffffffb1bc: cling::Interpreter::kSuccess, 
    result=0x7fffffffb200) at /opt/root_src/core/metacling/src/TCling.cxx:2448
#65393 0x00007ffff08135a3 in TCling::ProcessLine (this=0x5555557ec5c0, line=0x7fffffffb810 ".Class", error=0x7fffffffb7b0) at /opt/root_src/core/metacling/src/TCling.cxx:2608
#65394 0x00007ffff74fb696 in TApplication::ProcessLine (this=0x5555557d5950, line=0x7fffffffb810 ".Class", sync=false, err=0x7fffffffb7b0) at /opt/root_src/core/base/src/TApplication.cxx:1539
#65395 0x00007ffff7bb7515 in TRint::ProcessLineNr (this=0x5555557d5950, filestem=0x7ffff7bc7eba "ROOT_cli_", line=0x7fffffffb810 ".Class", error=0x7fffffffb7b0)
    at /opt/root_src/core/rint/src/TRint.cxx:818
#65396 0x00007ffff7bb5cc0 in TRint::Run (this=0x5555557d5950, retrn=false) at /opt/root_src/core/rint/src/TRint.cxx:461
#65397 0x000055555555512c in main (argc=1, argv=0x7fffffffd988) at /opt/root_src/main/src/rmain.cxx:84

[github-actions]

Hi @Axel-Naumann,

It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.

Sincerely,
🤖

[ferdymercury]

Hi @Axel-Naumann this does not seem fixed yet on Ubuntu 22 at least, I tried with:

   ------------------------------------------------------------------
  | Welcome to ROOT 6.29/01                        https://root.cern |
  | (c) 1995-2022, The ROOT Team; conception: R. Brun, F. Rademakers |
  | Built for linuxx8664gcc on Dec 24 2022, 01:58:00                 |
  | From remotes/origin/master@v6-29-01-47-g37ac665419               |
  | With c++ (Ubuntu 11.3.0-1ubuntu1~22.04) 11.3.0                   |
  | Try '.help'/'.?', '.demo', '.license', '.credits', '.quit'/'.q'  |
   ------------------------------------------------------------------

typed .Class
and I got:

===========================================================================
struct std::_Head_base<_Idx, _Head, true>
SIZE: (NA) FILE: tuple LINE: -1
List of member variables: -------------------------------------------------


 *** Break *** segmentation violation



===========================================================
There was a crash.
This is the entire stack trace of all threads:
===========================================================
#0  0x00007f37ae96a45a in __GI___wait4 (pid=36789, stat_loc=stat_loc
entry=0x7ffd3cfe1cd8, options=options
entry=0, usage=usage
entry=0x0) at ../sysdeps/unix/sysv/linux/wait4.c:30
#1  0x00007f37ae96a41b in __GI___waitpid (pid=<optimized out>, stat_loc=stat_loc
entry=0x7ffd3cfe1cd8, options=options
entry=0) at ./posix/waitpid.c:38
#2  0x00007f37ae8d0bcb in do_system (line=<optimized out>) at ../sysdeps/posix/system.c:171
#3  0x00007f37af034824 in TUnixSystem::StackTrace() () from /tmp/root/lib/libCore.so.6.29
#4  0x00007f37af031b55 in TUnixSystem::DispatchSignals(ESignals) () from /tmp/root/lib/libCore.so.6.29
#5  <signal handler called>
#6  0x00007f37abf32000 in clang::ASTContext::getTypeInfoImpl(clang::Type const*) const () from /tmp/root/lib/libCling.so
#7  0x00007f37abf23b62 in clang::ASTContext::getTypeInfo(clang::Type const*) const () from /tmp/root/lib/libCling.so
#8  0x00007f37abf2ecab in clang::ASTContext::getTypeInfoInChars(clang::Type const*) const () from /tmp/root/lib/libCling.so
#9  0x00007f37abf2ed79 in clang::ASTContext::getTypeInfoInChars(clang::QualType) const () from /tmp/root/lib/libCling.so
#10 0x00007f37ac2694c5 in (anonymous namespace)::ItaniumRecordLayoutBuilder::LayoutField(clang::FieldDecl const*, bool) () from /tmp/root/lib/libCling.so
#11 0x00007f37ac26a907 in (anonymous namespace)::ItaniumRecordLayoutBuilder::LayoutFields(clang::RecordDecl const*) () from /tmp/root/lib/libCling.so
#12 0x00007f37ac264259 in clang::ASTContext::getASTRecordLayout(clang::RecordDecl const*) const () from /tmp/root/lib/libCling.so
#13 0x00007f37a95a49ca in cling::(anonymous namespace)::ClassPrinter::DisplayDataMembers(clang::CXXRecordDecl const*, unsigned int) const () from /tmp/root/lib/libCling.so
#14 0x00007f37a95a9167 in cling::(anonymous namespace)::ClassPrinter::DisplayClassDecl(clang::CXXRecordDecl const*) const () from /tmp/root/lib/libCling.so
#15 0x00007f37a95aa45a in cling::(anonymous namespace)::ClassPrinter::ProcessDecl(clang::DeclContext::decl_iterator) const () from /tmp/root/lib/libCling.so
#16 0x00007f37a95aa54b in cling::(anonymous namespace)::ClassPrinter::ProcessDecl(clang::DeclContext::decl_iterator) const () from /tmp/root/lib/libCling.so
#17 0x00007f37a95aab7b in cling::DisplayClass(llvm::raw_ostream&, cling::Interpreter const*, char const*, bool) () from /tmp/root/lib/libCling.so
#18 0x00007f37a959e89e in cling::MetaSema::actOnClassCommand(llvm::StringRef, bool) const () from /tmp/root/lib/libCling.so
#19 0x00007f37a95af7c1 in cling::MetaParser::isClassCommand() () from /tmp/root/lib/libCling.so
#20 0x00007f37a95afcc3 in cling::MetaParser::isCommand(cling::MetaSema::ActionResult&, cling::Value*) () from /tmp/root/lib/libCling.so
#21 0x00007f37a95992d0 in cling::MetaProcessor::process(llvm::StringRef, cling::Interpreter::CompilationResult&, cling::Value*, bool) () from /tmp/root/lib/libCling.so
#22 0x00007f37a93c259c in HandleInterpreterException(cling::MetaProcessor*, char const*, cling::Interpreter::CompilationResult&, cling::Value*) () from /tmp/root/lib/libCling.so
#23 0x00007f37a93dbd6a in TCling::ProcessLine(char const*, TInterpreter::EErrorCode*) () from /tmp/root/lib/libCling.so
#24 0x00007f37af2f92e0 in TRint::ProcessLineNr(char const*, char const*, int*) () from /tmp/root/lib/libRint.so.6.29
#25 0x00007f37af2f97dc in TRint::HandleTermInput() () from /tmp/root/lib/libRint.so.6.29
#26 0x00007f37af030abc in TUnixSystem::CheckDescriptors() () from /tmp/root/lib/libCore.so.6.29
#27 0x00007f37af032888 in TUnixSystem::DispatchOneEvent(bool) () from /tmp/root/lib/libCore.so.6.29
#28 0x00007f37aef3aaa7 in TSystem::Run() () from /tmp/root/lib/libCore.so.6.29
#29 0x00007f37aeed0ec7 in TApplication::Run(bool) () from /tmp/root/lib/libCore.so.6.29
#30 0x00007f37af2fb39b in TRint::Run(bool) () from /tmp/root/lib/libRint.so.6.29
#31 0x000055669a43b2f3 in main ()
===========================================================


The lines below might hint at the cause of the crash. If you see question
marks as part of the stack trace, try to recompile with debugging information
enabled and export CLING_DEBUG=1 environment variable before running.
You may get help by asking at the ROOT forum https://root.cern/forum
Only if you are really convinced it is a bug in ROOT then please submit a
report at https://root.cern/bugs Please post the ENTIRE stack trace
from above as an attachment in addition to anything else
that might help us fixing this issue.
===========================================================
#6  0x00007f37abf32000 in clang::ASTContext::getTypeInfoImpl(clang::Type const*) const () from /tmp/root/lib/libCling.so
#7  0x00007f37abf23b62 in clang::ASTContext::getTypeInfo(clang::Type const*) const () from /tmp/root/lib/libCling.so
#8  0x00007f37abf2ecab in clang::ASTContext::getTypeInfoInChars(clang::Type const*) const () from /tmp/root/lib/libCling.so
#9  0x00007f37abf2ed79 in clang::ASTContext::getTypeInfoInChars(clang::QualType) const () from /tmp/root/lib/libCling.so
#10 0x00007f37ac2694c5 in (anonymous namespace)::ItaniumRecordLayoutBuilder::LayoutField(clang::FieldDecl const*, bool) () from /tmp/root/lib/libCling.so
#11 0x00007f37ac26a907 in (anonymous namespace)::ItaniumRecordLayoutBuilder::LayoutFields(clang::RecordDecl const*) () from /tmp/root/lib/libCling.so
#12 0x00007f37ac264259 in clang::ASTContext::getASTRecordLayout(clang::RecordDecl const*) const () from /tmp/root/lib/libCling.so
#13 0x00007f37a95a49ca in cling::(anonymous namespace)::ClassPrinter::DisplayDataMembers(clang::CXXRecordDecl const*, unsigned int) const () from /tmp/root/lib/libCling.so
#14 0x00007f37a95a9167 in cling::(anonymous namespace)::ClassPrinter::DisplayClassDecl(clang::CXXRecordDecl const*) const () from /tmp/root/lib/libCling.so
#15 0x00007f37a95aa45a in cling::(anonymous namespace)::ClassPrinter::ProcessDecl(clang::DeclContext::decl_iterator) const () from /tmp/root/lib/libCling.so
#16 0x00007f37a95aa54b in cling::(anonymous namespace)::ClassPrinter::ProcessDecl(clang::DeclContext::decl_iterator) const () from /tmp/root/lib/libCling.so
#17 0x00007f37a95aab7b in cling::DisplayClass(llvm::raw_ostream&, cling::Interpreter const*, char const*, bool) () from /tmp/root/lib/libCling.so
#18 0x00007f37a959e89e in cling::MetaSema::actOnClassCommand(llvm::StringRef, bool) const () from /tmp/root/lib/libCling.so
#19 0x00007f37a95af7c1 in cling::MetaParser::isClassCommand() () from /tmp/root/lib/libCling.so
#20 0x00007f37a95afcc3 in cling::MetaParser::isCommand(cling::MetaSema::ActionResult&, cling::Value*) () from /tmp/root/lib/libCling.so
#21 0x00007f37a95992d0 in cling::MetaProcessor::process(llvm::StringRef, cling::Interpreter::CompilationResult&, cling::Value*, bool) () from /tmp/root/lib/libCling.so
#22 0x00007f37a93c259c in HandleInterpreterException(cling::MetaProcessor*, char const*, cling::Interpreter::CompilationResult&, cling::Value*) () from /tmp/root/lib/libCling.so
===========================================================

[Axel-Naumann]

Sorry & thanks! Then we won't make it for 6.28/00...